Repository navigation
fix: Speak unfenced tables without "comma" between rows (#890) - #915
Open
moritz-gross wants to merge 1 commit into
Open
moritz-gross wants to merge 1 commit into
moritz-gross wants to merge 1 commit into
Conversation
A table with no fences gets the `array` intent, but English had no speech
rule for `array`, so it fell through to the catch-all function rule
("array of x comma y") and spoke "comma" between the rows.
The English default table rule now handles `array` as well as `mtable`,
as Portuguese already does. This also fixes `NumColumns=1` (missing `$`),
which always gave "columns", e.g. "1 columns".
Updates 4 expected strings in tests/Languages/en/mtable.rs and adds a
test using the MathML from the issue.
Linux library size: 0.59 MiB (0.00%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
Collaborator
|
I'm leaning towards that it should be spoken as "array with ..." as opposed to "table with ...". Thoughts? Also, in looking into this, I realized that the |
Collaborator
Author
|
I'm also in team array |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A table with no fences gets the
arrayintent, but English had no speech rule forarray, so it fell through to the catch-all function rule ("array of x comma y") and spoke "comma" between the rows.The English default table rule now handles
arrayas well asmtable, as Portuguese already does. This also fixesNumColumns=1(missing$), which always gave "columns", e.g. "1 columns".Updates 4 expected strings in tests/Languages/en/mtable.rs and adds a test using the MathML from the issue.
I think this already fixes it. More broadly, my question is how we want to treat "table" / "array" / "matrix" as different types of objects, or not.