Skip to content

More tests for Finnish 6-dot braille and some fixes - #858

Open
samimaattaCelia wants to merge 83 commits into
daisy:fi-braillefrom
samimaattaCelia:fi-braille
Open

samimaattaCelia wants to merge 83 commits into
daisy:fi-braillefrom
samimaattaCelia:fi-braille

Conversation

@samimaattaCelia

@samimaattaCelia samimaattaCelia commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Relates to #501
I went through the tests I had made before and compared them with the specification and the Finnish curriculum, so that the tests would cover them well enough.

I also made some fixes to some tests' MathML and the braille output.

If more tests are needed, then I need more information on what kind of tests, since to me these seem to cover pretty well what is expected of the 6-dot braille. It is mainly used for comprehensive school levels of mathematics.

@moritz-gross

Copy link
Copy Markdown
Collaborator

some checks initially failed because of a problem with the "zip" package that MathCAT depends on.
I have rerun them as the authors seem to have fixed it, but now there are failures regarding the Finnish tests it seems?

@samimaattaCelia can you click on the failing tests and see if the logs are helpful to you?

@samimaattaCelia

Copy link
Copy Markdown
Contributor Author

Do you mean the tests that are not passing? If so, then the rules need to be changed so the tests pass.

@moritz-gross

moritz-gross commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Do you mean the tests that are not passing? If so, then the rules need to be changed so the tests pass.

yes, 2 jobs are failing.

image

I copied part of the log where it shows the failing tests:

here

failures:
    braille::Finnish::spec::chemical_formula_parentheses_2
    braille::Finnish::spec::half_open_interval_right
    braille::Finnish::spec::matrix_with_empty_cells
    braille::Finnish::spec::msub_with_vector
    braille::Finnish::spec::msub_with_vector_arrow
    braille::Finnish::spec::msub_with_vector_with_sub_text
    braille::Finnish::spec::msubsup_with_vector
    braille::Finnish::spec::msubsup_with_vector_complex_with_parentheses
    braille::Finnish::spec::nth_order_derivative
    braille::Finnish::spec::open_interval
    braille::Finnish::spec::operate_by_on_both_sides
    braille::Finnish::spec::operate_by_on_both_sides_double_bars
    braille::Finnish::spec::p16_division
    braille::Finnish::spec::p17_multiple_operations
    braille::Finnish::spec::p22_equation_solving_notation
    braille::Finnish::spec::p22_equation_solving_notation_double_bars
    braille::Finnish::spec::p22_fraction_division_Finnish_notation_mmultiscripts
    braille::Finnish::spec::p25_long_fraction
    braille::Finnish::spec::p46_first_order_derivative_alt
    braille::Finnish::spec::p49_integral_with_Finnish_notation_for_substitution
    braille::Finnish::spec::p49_sequence_with_lower_upper_bounds
    braille::Finnish::spec::p49_summation_with_lower_upper_bounds
    braille::Finnish::spec::p50_binomial_with_factorial
    braille::Finnish::spec::second_order_derivative_alt_1
    braille::Finnish::spec::second_order_derivative_alt_2

test result: FAILED. 1476 passed; 25 failed; 31 ignored; 0 measured; 0 filtered out; finished in 16.54s

A pull request can only be merged if the checks pass, so it it needs to be fixed first. can you see why/how the checks fail?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

3 participants