single: check the allocs on debug, run the rest optimized - #20
Closed
bagder wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The benchmark linkage and log truncation issues must be addressed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Separates debug allocation checks from optimized performance benchmarks.
Changes:
- Runs memory analysis with a debug build.
- Rebuilds without debug instrumentation for benchmarks.
- Updates build-stage logging.
File summaries
| File | Review |
|---|---|
single.sh |
Splits debug checks from benchmarks. Restore --disable-shared to avoid changing linkage, and truncate maketests.log per run to prevent stale results and unbounded growth. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.