docs: the consumer pattern — the in-repo half of the browser testing convention - #62
Merged
Conversation
…convention The reusable workflow's README covers CI wiring and the pin chain; nothing covered what a consuming repo looks like on the inside, so each adopter would reverse-engineer nmon and diverge. docs/playwright-consumer.md is that half: the root-manifest contract lockstep assumes, the exact-pin + renovate-rule npm conventions, the config baseline (derived port, vite preview of BUILT assets, report paths matching the artifact glob), the test-layout split, the starter smoke (a selector only the booted app produces, plus no page errors — never a bare HTTP 200), and the subdirectory-frontend shape. nmon stays the living reference throughout. Closes #61 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ntainer Surfaced by the Atlas/Topology seeds: vite preview's default localhost bind inside the job container is IPv6-only (::1) while the webServer probe dials 127.0.0.1, so the suite times out on a server that is up — and passes on a dev host, which binds both families. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
docs/playwright-consumer.md— the consumer-facing half of the browser testing convention (parent: #60), living next to the reusable workflow so it versions with the interface it documents — and links it from the README'splaywright-test.ymlsection.Covers the in-repo half only: the root-manifest contract the
lockstepjob assumes, exact@playwright/testpin + lockfile agreement + the Renovate disable rule, the Playwright config baseline (checkout-derived port per nmon#47,webServerbooting built assets viavite preview, report paths matching the workflow's failure-artifact glob), test directory layout, the starter smoke shape (a selector only the booted app produces AND a no-page-errors assertion — never a bare HTTP 200), and the subdirectory-frontend harness shape (Topology's case). CI wiring stays in the README; nmon is cited as the living reference throughout.Closes #61
🤖 Generated with Claude Code