-
-
Notifications
You must be signed in to change notification settings - Fork 56
feat!: Use a radix trie for route matching #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ElijahAhianyo
wants to merge
20
commits into
master
Choose a base branch
from
elijah/router-trie
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
22b582e
Use a radix trie for route matching
ElijahAhianyo 0f58776
chore(pre-commit.ci): auto fixes from pre-commit hooks
pre-commit-ci[bot] 6af73da
common_prefix_len can use bytes since in practice routes are ascii based
ElijahAhianyo 6d29052
Merge remote-tracking branch 'origin/elijah/router-trie' into elijah/…
ElijahAhianyo 6b56ed1
Use Matchit crate
ElijahAhianyo 7ee8813
Add tests with lots and lots of improvements!
ElijahAhianyo 8bc1712
Merge branch 'master' into elijah/router-trie
ElijahAhianyo fb47870
make clippy happy
ElijahAhianyo 0ba361b
doctest fix
ElijahAhianyo 89dc1ee
remove print
ElijahAhianyo 9251215
Merge branch 'master' into elijah/router-trie
ElijahAhianyo eefac7c
fix tests after merge conflict resolution
ElijahAhianyo 994cbe6
fix UI tests, more improvs
ElijahAhianyo a176534
chore(pre-commit.ci): auto fixes from pre-commit hooks
pre-commit-ci[bot] 0a257a7
add more tests
ElijahAhianyo f5d3214
lint
ElijahAhianyo 189751b
comments
ElijahAhianyo 020cc77
revert snapshot
ElijahAhianyo 9a9c074
Merge branch 'master' into elijah/router-trie
ElijahAhianyo 3d85d8b
clippy fix
ElijahAhianyo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, we should probably modify the URL routes to include the trailing slashes.