-
-
Notifications
You must be signed in to change notification settings - Fork 57
feat!: consolidate cot cli commands into one #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ElijahAhianyo
wants to merge
55
commits into
master
Choose a base branch
from
elijah/cot-proxy-cmd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
fc8f8f1
consolidate cot cli commands into one
ElijahAhianyo 683b2a6
remove dead code
ElijahAhianyo 8a0c6b8
- improve error messages.
ElijahAhianyo 2a4bfba
Merge branch 'master' into elijah/cot-proxy-cmd
ElijahAhianyo d73cd10
unit tests initial
ElijahAhianyo 219d898
Merge branch 'master' into elijah/cot-proxy-cmd
ElijahAhianyo 0cfd155
some minor refactor
ElijahAhianyo 9beb8ea
fix clippy
ElijahAhianyo 48353cb
fix the snapshot tests
ElijahAhianyo 00016d3
gate unix::process::CommandExt behind unix flag
ElijahAhianyo 7f85e45
fix exec error on windows
ElijahAhianyo 86cfd37
chore(pre-commit.ci): auto fixes from pre-commit hooks
pre-commit-ci[bot] 9c9b467
make serde_json a required dep
ElijahAhianyo 4e7b5d6
comment improve
ElijahAhianyo ea45e71
Merge branch 'master' into elijah/cot-proxy-cmd
ElijahAhianyo 464b3c0
Merge branch 'master' into elijah/cot-proxy-cmd
ElijahAhianyo 8001727
update lock files
ElijahAhianyo 0412722
update snapshots
ElijahAhianyo 99ff86e
Merge branch 'master' into elijah/cot-proxy-cmd
ElijahAhianyo 29ade27
fix merge conflicts
ElijahAhianyo 84d8f10
Merge branch 'master' into elijah/cot-proxy-cmd
m4tx 51b6c20
address PR comments. Also some refactor and fixed loads of bugs to im…
ElijahAhianyo b02da44
comment improve
ElijahAhianyo 545e976
Add test harness
ElijahAhianyo ca25425
rename project harness for consistency
ElijahAhianyo 56ddeff
fix ui tests
ElijahAhianyo 3d9ad2f
fix dependency mess(hopefully)
ElijahAhianyo 9336b24
normalize path separator dor windows
ElijahAhianyo 8387bc9
fix docstring. Temporarily revert request ui tests to see if CI passes
ElijahAhianyo 5bfe9fd
chore(pre-commit.ci): auto fixes from pre-commit hooks
pre-commit-ci[bot] ac5f8bc
adding some debug statements to instrument windows CI failure
ElijahAhianyo 5e7f46f
Merge remote-tracking branch 'origin/elijah/cot-proxy-cmd' into elija…
ElijahAhianyo abe2318
chore(pre-commit.ci): auto fixes from pre-commit hooks
pre-commit-ci[bot] 6acd271
should compile now
ElijahAhianyo f6fcd3d
Merge remote-tracking branch 'origin/elijah/cot-proxy-cmd' into elija…
ElijahAhianyo ffe7e72
isolating tests
ElijahAhianyo 6590dc1
see if windows test gets fixed
ElijahAhianyo 3669369
try to build if bin not found
ElijahAhianyo d51c000
chore(pre-commit.ci): auto fixes from pre-commit hooks
pre-commit-ci[bot] 5a6f0f2
use status so child forwards to parent on windows. see if it works
ElijahAhianyo e0cc344
Merge remote-tracking branch 'origin/elijah/cot-proxy-cmd' into elija…
ElijahAhianyo afc507e
fix miri tests. Also a couple of improvements
ElijahAhianyo d2a8549
fix docs test
ElijahAhianyo 43d79ce
address roughly 85% of comments
ElijahAhianyo 12c56a2
Merge branch 'master' into elijah/cot-proxy-cmd
ElijahAhianyo 7716b12
address 2 more comments
ElijahAhianyo 73ae4ef
add some tests to handle target-dir discovery
ElijahAhianyo d8dcb36
normalize path in windows to fix tests
ElijahAhianyo edea1c3
fix flaky tests
ElijahAhianyo b32dc83
fix help tests
ElijahAhianyo a98e8e8
miri ignore
ElijahAhianyo b510092
Merge branch 'master' into elijah/cot-proxy-cmd
ElijahAhianyo e099107
Merge branch 'master' into elijah/cot-proxy-cmd
ElijahAhianyo f0486dc
Merge remote-tracking branch 'origin/elijah/cot-proxy-cmd' into elija…
ElijahAhianyo 515cab1
clippy fix
ElijahAhianyo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also handle cases like
cot check -- -p packagehere? (and if so, we should have tests for these as well)Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is only called in
main()after we split on--to differentiate internal args from args forwarded to the binary. In practice, it wouldn't receive raw args, but I've added a defensive check to the function to handle that case.Also, shouldn't this be
cot check -p packageinstead ofcot check -- -p package? I'd imagine that external args (args after the--delimiter) are forwarded to the binary, so we should expect this to throw an error.That also brings me to this scenario: commands like
migration rollback,collect-static, andchecklive in the binary and are treated as external commands from the perspective of cot-cli, just like custom commands. However, we market these commands as first-class cot-cli commands to end users. So users would expect all cot commands to follow the same convention, with args coming before the delimiter, rather than having to figure out which internal commands require args after the delimiter and which require args before.I think as a follow-up to this PR, we should have some mechanism to make cot-cli aware of what commands to treat as first-class citizens, and also maybe a way to make
CliTaskaware of flags already registered by cot-cli (like--packageand--release).What do you think?