CHG: Removed old DEE modules from compilation procedure#175
Merged
Conversation
zoglauer
added
cleanup
fhagemann
requested changes
Jun 29, 2026
| NUCLEARIZER_DIR := $(NUCLEARIZER) | ||
| NUCLEARIZER_PRG := $(BN)/nuclearizer | ||
| NUCLEARIZER_CXX_MAIN := $(NUCLEARIZER_DIR)/src/MNuclearizerMain.cxx | ||
| NUCLEARIZER_CXX_FILTERED := $(NUCLEARIZER_CXX_MAIN) $(NUCLEARIZER_DIR)/src/MModuleTemplate.cxx $(NUCLEARIZER_DIR)/src/MDetectorEffectsEngineSingleDet.cxx $(NUCLEARIZER_DIR)/src/MDetectorEffectsEngineSMEX.cxx $(NUCLEARIZER_DIR)/src/MModuleLoaderSimulationsSingleDet.cxx $(NUCLEARIZER_DIR)/src/MModuleLoaderSimulationsSMEX.cxx $(NUCLEARIZER_DIR)/src/MGUIOptionsLoaderSimulations.cxx $(NUCLEARIZER_DIR)/src/MGUIOptionsDEESMEX.cxx |
There was a problem hiding this comment.
Suggested change
| NUCLEARIZER_CXX_FILTERED := $(NUCLEARIZER_CXX_MAIN) $(NUCLEARIZER_DIR)/src/MModuleTemplate.cxx $(NUCLEARIZER_DIR)/src/MDetectorEffectsEngineSingleDet.cxx $(NUCLEARIZER_DIR)/src/MDetectorEffectsEngineSMEX.cxx $(NUCLEARIZER_DIR)/src/MModuleLoaderSimulationsSingleDet.cxx $(NUCLEARIZER_DIR)/src/MModuleLoaderSimulationsSMEX.cxx $(NUCLEARIZER_DIR)/src/MGUIOptionsLoaderSimulations.cxx $(NUCLEARIZER_DIR)/src/MGUIOptionsDEESMEX.cxx | |
| NUCLEARIZER_CXX_FILTERED := $(NUCLEARIZER_CXX_MAIN) $(NUCLEARIZER_DIR)/src/MModuleTemplate.cxx $(NUCLEARIZER_DIR)/src/MDetectorEffectsEngineSingleDet.cxx $(NUCLEARIZER_DIR)/src/MDetectorEffectsEngineSMEX.cxx $(NUCLEARIZER_DIR)/src/MModuleLoaderSimulationsSingleDet.cxx $(NUCLEARIZER_DIR)/src/MModuleLoaderSimulationsSMEX.cxx $(NUCLEARIZER_DIR)/src/MGUIOptionsLoaderSimulations.cxx |
We still need MGUIOptionsDEESMEX.cxx, which is for the new DEE.
My make process throws an error with the Makefile as currently implemented in this PR.
There was a problem hiding this comment.
Compiling and linking nuclearizer ...
/usr/bin/ld: ~/Software/COSItools/megalib/lib/libNuclearizer.so: undefined reference to `MGUIOptionsDEESMEX::MGUIOptionsDEESMEX(MModule*)'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:189: ~/Software/COSItools/megalib/bin/nuclearizer] Error 1
make: *** [Makefile:127: all] Error 2
Collaborator
Author
|
I see it. I should have "made clean" before I changed the Makefile, thus the old *.o files were still laying around after a make clean... and it compiled without issues. |
fhagemann
approved these changes
Jun 29, 2026
|
Also, this is the first time that the GitHub action tests caught something: https://github.com/cositools/nuclearizer/actions/runs/28405528108 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the old DEE modules from the code and compilation, but kept the files around.
This addresses:
#170