Skip to content

fix: add path validation in cleanup-path.ts #7356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anupamme wants to merge 1 commit into from
Closed

fix: add path validation in cleanup-path.ts #7356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/cli/command/cleanup-path.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ export class CleanupPathCommand extends Command {
const start = Date.now();
let error = false;
const paths = this.cleanupPaths.flatMap((p) => p.split(':'));

// reject path traversal sequences to avoid deleting files outside of the requested paths
const invalid = paths.filter((p) => /(^|[/\\])\.\.([/\\]|$)/.test(p));
if (invalid.length) {
logger.error({ paths: invalid }, 'Invalid cleanup path(s) detected');
return 1;
}

logger.info({ paths }, `Cleanup paths ...`);
try {
const deleted = await deleteAsync(paths, { dot: true });
Expand Down
Loading