Repository navigation
host, router: safe bin-overrides for merged-usr + controller re-resolve - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/bin→usr/binsymlink) and writes overrides intousr/binin the overlay upperdir. Previously the unconditionalMkdirAll(diffDir/bin)shadowed the symlink, hiding/usr/binfrom every process and crash-looping apps (fixes thefork/exec /runner/init: no such file or directoryregression observed on the lab cluster when bin-overrides was used). Adds alayerMergedUsrunit test.ControllerStoreno longer pins the first discoverdcontrollerinstance at startup.List()/Watch()now re-resolve the live instance set on every call and fall through all instances until one accepts the request. This fixes the router silently missing route/cert updates after the controller it was connected to dies/is replaced (symptom:tlsv1 alert internal erroron new HTTPS routes).Verification
go build ./router ./hostboth pass.go test -run TestLayerMergedUsr -v ./hostpasses (4 subcases).