Skip to content

Honor the mapped page template when creating pages #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hissy wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

Honor the mapped page template when creating pages #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...s/Concrete5/MigrationTool/Publisher/Command/Handler/CreatePageStructureCommandHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@ private function createRegularPage(Batch $batch, ?CCMPage $ccmParentPage, MTPage
];
$localeInfo = $mtPage->getLocaleRoot();
if ($localeInfo === null || $batch->isPublishToSitemap() !== true || $this->localeAlreadyExists($batch, $localeInfo)) {
return $ccmParentPage->add($pageType, $data);
// Page::add() ignores $data['pTemplateID'] and falls back to the page type's
// default template unless the template is passed as the third argument.
return $ccmParentPage->add($pageType, $data, $pageTemplate ?: false);
}
if (!$pageTemplate) {
throw new UserMessageException(t('Missing page template when creating the home of a language'));
Expand Down
Loading