Add argument to parse headers via a source's flags#58
Open
Steelskin wants to merge 1 commit into
Open
Conversation
idt requires input to have an entry in the compilation database in order to be properly parsed. This is not always the case when parsing headers, depending on the project configuration. This change adds `--cdb-source=<path>`. When set, idt looks up `<path>` in the compilation database and adjusts the command line to parse the positional argument with the same flags as `<path>`, assuming that the positional argument is a header. Fixits are gated behind the `is_in_main_tu()` helper when `--cdb-source` is set to prevent spilling of fixits outside of the positional input. The helper is a no-op otherwise, preserving existing behavior.
36 tasks
compnerd
reviewed
May 13, 2026
| llvm::cl::cat(idt::category)); | ||
|
|
||
| llvm::cl::opt<std::string> | ||
| cdb_source("cdb-source", |
| static void rewrite(clang::tooling::CompileCommand &command, | ||
| llvm::StringRef path) { | ||
| static constexpr std::array<llvm::StringRef, 5> kSourceExts{ | ||
| ".cpp", ".cc", ".cxx", ".c++", ".C"}; |
Owner
There was a problem hiding this comment.
Suggested change
| ".cpp", ".cc", ".cxx", ".c++", ".C"}; | |
| ".cpp", ".cc", ".cxx", ".c++", ".C", | |
| }; |
Comment on lines
+823
to
+833
| // Enforce `-x c++-header`. Replace any existing `-x <lang>` value, or | ||
| // insert `-x c++-header` immediately after argv[0]. | ||
| auto x_it = | ||
| std::find(command.CommandLine.begin(), command.CommandLine.end(), "-x"); | ||
| if (x_it != command.CommandLine.end() && | ||
| std::next(x_it) != command.CommandLine.end()) { | ||
| *std::next(x_it) = "c++-header"; | ||
| } else if (!command.CommandLine.empty()) { | ||
| command.CommandLine.insert(std::next(command.CommandLine.begin()), | ||
| {"-x", "c++-header"}); | ||
| } |
Owner
There was a problem hiding this comment.
This needs an explanation as to why we are using C++ as the language. Also, why are we using c++header?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
idt requires input to have an entry in the compilation database in order to be properly parsed. This is not always the case when parsing headers, depending on the project configuration.
This change adds
--cdb-source=<path>. When set, idt looks up<path>in the compilation database and adjusts the command line to parse the positional argument with the same flags as<path>, assuming that the positional argument is a header.Fixits are gated behind the
is_in_main_tu()helper when--cdb-sourceis set to prevent spilling of fixits outside of the positional input. The helper is a no-op otherwise, preserving existing behavior.