feat: modernize RPM spec for Fedora Go packaging guidelines - #826
Merged
marcusburghardt merged 5 commits intoAug 27, 2026
Merged
Conversation
marcusburghardt
force-pushed
the
opsx/rpm-spec-modernization
branch
4 times, most recently
from
August 26, 2026 09:08
f7e42d7 to
f893adf
Compare
marcusburghardt
force-pushed
the
opsx/rpm-spec-modernization
branch
2 times, most recently
from
August 27, 2026 11:45
08a157e to
c2e8240
Compare
marcusburghardt
marked this pull request as ready for review
August 27, 2026 11:46
marcusburghardt
requested review from
sedonnel and
trevor-vaughan
and removed request for
sedonnel
August 27, 2026 11:46
OpenSpec change proposal for modernizing the RPM spec file to align with Fedora Go packaging guidelines for the v1.0.0 release. Artifacts: proposal.md, design.md (9 decisions, D1-D9), tasks.md (28 tasks across 5 phases). Specs skipped (skip_specs: true) since this is a packaging infrastructure change with no application behavior modifications. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
- Remove %global debug_package %{nil} and switch to %gobuild macro
for proper debuginfo generation (build-id, DWARF, external linkmode)
- Add go-vendor-tools integration: Source1 vendor archive, Source2
config, %go_vendor_license_* macros for license verification
- Use %gocheck2 for unit tests with -t exclusions for non-unit paths
- Adopt %autorelease, %gometa -f, %goprep -A, %generate_buildrequires
- Generalize F43 vendor/modules.txt sed to match any Go version
- Set License to composite SPDX expression from go_vendor_license:
Apache-2.0 AND BSD-2-Clause AND BSD-3-Clause AND ISC AND MIT AND MPL-2.0
- Align Version to 1.0.0
Assisted-by: OpenCode (claude-opus-4-6)
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
- Add srpm_build_deps (go-vendor-tools, golang, askalono-cli) for Copr SRPM builds - Add post-modifications action for vendor archive generation using bash -c wrapper (required by Packit command tokenization) - Context detection via PACKIT_DOWNSTREAM_REPO for downstream vs upstream working directory - Use GOTOOLCHAIN=local (no auto-download in Fedora build env) - Sync go-vendor-tools.toml to dist-git via files_to_sync - Add create_sync_note: false - Remove CentOS Stream targets (go-vendor-tools unavailable) Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Askalono detector config with manual license entries for: - go.yaml.in/yaml/v3 and gopkg.in/yaml.v3 (dual MIT AND Apache-2.0) - mattn/go-localereader (MIT declared in README, no LICENSE file) Generated by go_vendor_license report --autofill=auto with scancode backend for undetected licenses. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
marcusburghardt
force-pushed
the
opsx/rpm-spec-modernization
branch
from
August 27, 2026 14:47
c2e8240 to
48fea72
Compare
Member
Author
|
Rebased |
marcusburghardt
enabled auto-merge (rebase)
August 27, 2026 14:50
trevor-vaughan
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernize
complyctl.specfor Fedora Go packaging guidelines before v1.0.0 release.Fixes #827
Changes
%global debug_package %{nil}, switch to%gobuildmacro (proper build-id, DWARF, external linkmode)Source1vendor archive,Source2config,%go_vendor_license_*macros for vendored license verification%gocheck2for unit tests,%autorelease,%gometa -f,%goprep -A,%generate_buildrequiressrpm_build_deps,post-modificationsaction for vendor archive generation, syncgo-vendor-tools.tomlto dist-gitvendor/modules.txtsed to match any Go version above 1.25go-vendor-toolsunavailable)Verification
Local RPM build verified:
rpmbuild -basucceeds with debuginfo subpackage producedrpmlintpasses (0 errors)%gocheck2runs unit tests with exclusions working correctlyrpmbuild --without checkpasses/usr/share/licenses/complyctl/Design
See
openspec/changes/rpm-spec-modernization/for proposal, design (9 decisions), and task tracking.Review Hints
This PR can be more easily tested in a Fedora VM using
complytime-demos: complytime/complytime-demos#81