[cpyrt] Import the cppjit module when gThisModule is null - #97
Merged
aaronj0 merged 1 commit intoSep 15, 2026
Merged
Conversation
Entering through the public API (Instance_FromVoidPtr) without importing cppjit leaves gThisModule null. With Python already initialized, Initialize() skipped the import and reported success anyway, so CreateScopeProxy() dereferenced null. Import the extension module whenever gThisModule is null.
vgvassilev
reviewed
Sep 9, 2026
| PyRun_SimpleString(const_cast<char*>("import cppjit")); | ||
| // Importing the extension module is what runs the cpyrt initialization | ||
| // that sets gThisModule. | ||
| if (!cpyrt::gThisModule) { |
Contributor
There was a problem hiding this comment.
Can we open an issue tracking the progress of removing global state?
Collaborator
There was a problem hiding this comment.
Sure, please go ahead! Would be useful if the issue said which globals you have in mind (gThisModule, gPyTypeMap, gMainDict, the PyString globals? ..) and what problem they cause (subinterpreters, teardown, etc.), so it's actionable rather than a general cleanup item. Because in general, global "immortal" state is not an anti-pattern in CPython.
Collaborator
Author
There was a problem hiding this comment.
I'm currently investigating this and will open an issue with more details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entering through the public API (Instance_FromVoidPtr) without importing cppjit leaves gThisModule null. With Python already initialized, Initialize() skipped the import and reported success anyway, so CreateScopeProxy() dereferenced null. Import the extension module whenever gThisModule is null.