Repository navigation
Helper for FunctionTemplateDecl -> FunctionDecl - #1104
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| // Resolves the FunctionDecl a decl names, looking through a using-shadow and | ||
| // a template pattern. Null when the decl does not name a function. | ||
| static const clang::FunctionDecl* UnwrapToFunctionDecl(const clang::Decl* D) { |
Contributor
There was a problem hiding this comment.
warning: unused function 'UnwrapToFunctionDecl' [clang-diagnostic-unused-function]
function.
^
Vipul-Cariappa
left a comment
Vipul-Cariappa
left a comment
Collaborator
There was a problem hiding this comment.
This is fine, I guess. But could you also add its usages in the existing code?
…nce this pattern written at least four times by me, to not repeat code I wrote this helper
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1104 +/- ##
==========================================
- Coverage 88.53% 88.52% -0.02%
==========================================
Files 24 24
Lines 6858 6851 -7
==========================================
- Hits 6072 6065 -7
Misses 786 786
🚀 New features to boost your workflow:
|
Vipul-Cariappa
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used this pattern at least four times and going to use again, so a helper removes repeating code
@Vipul-Cariappa