Skip to content

fix: skip _ inside attributes when only the attributes plugin is on - #374

Merged
farnabaz merged 1 commit into
comarkdown:mainfrom
BetterAndBetterII:fix/attributes-underscore-only-plugin
Aug 25, 2026
Merged

fix: skip _ inside attributes when only the attributes plugin is on#374
farnabaz merged 1 commit into
comarkdown:mainfrom
BetterAndBetterII:fix/attributes-underscore-only-plugin

Conversation

@BetterAndBetterII

Copy link
Copy Markdown
Contributor

Summary

  • With only the attributes plugin enabled, target=_blank no longer auto-closes as italic and appends a leftover underscore.
  • Auto-close skips attribute braces whenever attributes is registered, without enabling component fences.

Fixes #362

Test plan

  • vitest default-plugins and auto-close tests
  • full comark suite 1427 passed, 2 todo

@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

@BetterAndBetterII is attempting to deploy a commit to the NuxtLabs Team on Vercel.

A member of the Team first needs to authorize it.

@pkg-pr-new

pkg-pr-new Bot commented Aug 25, 2026

Copy link
Copy Markdown

Open in StackBlitz

comark

npm i https://pkg.pr.new/comark@374

@comark/angular

npm i https://pkg.pr.new/@comark/angular@374

@comark/ansi

npm i https://pkg.pr.new/@comark/ansi@374

@comark/html

npm i https://pkg.pr.new/@comark/html@374

@comark/nuxt

npm i https://pkg.pr.new/@comark/nuxt@374

@comark/react

npm i https://pkg.pr.new/@comark/react@374

@comark/svelte

npm i https://pkg.pr.new/@comark/svelte@374

@comark/vue

npm i https://pkg.pr.new/@comark/vue@374

commit: 70e39bd

auto-close treated {target="_blank"} as italic and appended _. Enable attribute-brace skipping whenever the attributes plugin is registered, without turning on component fences.

Co-authored-by: Yuzhong Zhang <BetterAndBetterII@users.noreply.github.com>

@farnabaz farnabaz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@farnabaz
farnabaz merged commit 9631306 into comarkdown:main Aug 25, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extra underscore appended when only using the attributes plugin

2 participants