Skip to content

feat(communication): validate duplicate IPs in ConnectedAP within the same SubNetwork#101

Merged
noraeb merged 3 commits into
mainfrom
feature/ip-already-in-use
Jul 6, 2026
Merged

feat(communication): validate duplicate IPs in ConnectedAP within the same SubNetwork#101
noraeb merged 3 commits into
mainfrom
feature/ip-already-in-use

Conversation

@lorenzhoerburgerbearingpointcom

@lorenzhoerburgerbearingpointcom lorenzhoerburgerbearingpointcom commented Jul 3, 2026

Copy link
Copy Markdown

This PR adds IP validation to the ConnectedAP edit wizard (Communication Plugin).

What changed

  • Added duplicate-IP validation for the IP field against other ConnectedAP entries in the same SubNetwork.
  • Added support in wizard-textfield for a custom reserved-value validation message.
  • Wired ConnectedAP IP validation to show a clearer error message when the IP is already used.
  • Added unit tests for duplicate-IP validation.

Example SCD snippet (duplicate IP in same SubNetwork):

<SubNetwork name="StationBus" type="8-MMS">
  <ConnectedAP iedName="IED1" apName="P1">
    <Address>
      <P type="IP">192.168.210.111</P>
      <P type="IP-SUBNET">255.255.255.0</P>
      <P type="IP-GATEWAY">192.168.210.1</P>
      ...
    </Address>
  </ConnectedAP>

  <ConnectedAP iedName="IED2" apName="P1">
    <Address>
      <P type="IP">192.168.210.111</P>
      <P type="IP-SUBNET">255.255.255.0</P>
      <P type="IP-GATEWAY">192.168.210.1</P>
      ...
    </Address>
  </ConnectedAP>
</SubNetwork>
image

Context

This PR was first created in in com-pas/compas-open-scd. It was already reviewed and the feedback is implemented in this PR.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-07-06 06:53 UTC

@noraeb noraeb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lorenzhoerburgerbearingpointcom Looks good to me, do you have the rights to merge the PR?

@lorenzhoerburgerbearingpointcom

Copy link
Copy Markdown
Author

Hi @noraeb thanks for the review. No I don't have the permissions to merge.

@noraeb noraeb merged commit 568c944 into main Jul 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants