feat(communication): validate duplicate IPs in ConnectedAP within the same SubNetwork#101
Merged
Conversation
|
noraeb
approved these changes
Jul 6, 2026
noraeb
left a comment
Collaborator
There was a problem hiding this comment.
@lorenzhoerburgerbearingpointcom Looks good to me, do you have the rights to merge the PR?
Author
|
Hi @noraeb thanks for the review. No I don't have the permissions to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds IP validation to the ConnectedAP edit wizard (Communication Plugin).
What changed
Example SCD snippet (duplicate IP in same SubNetwork):
Context
This PR was first created in in com-pas/compas-open-scd. It was already reviewed and the feedback is implemented in this PR.