fix/add getter for editorComponent#353
Open
7eliassen wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Fixes a bug where element on the exposed editor API captured editorComponent.value at setup time (before mount), causing it to always be null. Converting it to a getter ensures consumers receive the current ref value when accessed.
Changes:
- Replace static
elementproperty with a getter that returnseditorComponent.valueon access.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
neSpecc
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the user changes a note, the note screenshot isn't being taken and note covers aren't updating on the server. This happens because the editor holder was assigned before actual mounting and it references null.
Solution
Add
elementgetter for getting actual editorComponent.value.