Skip to content

🤖 tests: wait for background exits instead of fixed sleeps before reading output #5607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasK33 merged 1 commit into from
Oct 4, 2026
Merged

🤖 tests: wait for background exits instead of fixed sleeps before reading output #5607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions tests/ipc/runtime/backgroundBashDirect.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,9 @@ describe("Background Bash Direct Integration", () => {
expect(spawnResult.success).toBe(true);
const processId = spawnResult.backgroundProcessId!;

await new Promise((resolve) => setTimeout(resolve, 200));
// Wait for the exit, not a fixed delay: on Windows the process can start writing later than
// 200 ms, and the read below then saw an empty output (#5606).
await waitForProcessExit(manager, processId, PROCESS_EXIT_TIMEOUT_MS);

// Message 2: Read with NEW tool instances (same manager)
const bashOutput2 = createBashOutputTool(toolConfig);
Expand Down Expand Up @@ -217,7 +219,7 @@ describe("Background Bash Direct Integration", () => {
expect(spawnResult.success).toBe(true);
if (!spawnResult.success) return;

await new Promise((resolve) => setTimeout(resolve, 200));
await waitForProcessExit(manager, spawnResult.processId, PROCESS_EXIT_TIMEOUT_MS);

const output = await manager.getOutput(spawnResult.processId);
expect(output.success).toBe(true);
Expand Down Expand Up @@ -373,7 +375,7 @@ describe("Background Bash Output Capture", () => {
expect(spawnResult.success).toBe(true);
if (!spawnResult.success) return;

await new Promise((resolve) => setTimeout(resolve, 300));
await waitForProcessExit(manager, spawnResult.processId, PROCESS_EXIT_TIMEOUT_MS);

const output = await manager.getOutput(spawnResult.processId);
expect(output.success).toBe(true);
Expand All @@ -400,7 +402,7 @@ describe("Background Bash Output Capture", () => {
expect(spawnResult.success).toBe(true);
if (!spawnResult.success) return;

await new Promise((resolve) => setTimeout(resolve, 300));
await waitForProcessExit(manager, spawnResult.processId, PROCESS_EXIT_TIMEOUT_MS);

const output = await manager.getOutput(spawnResult.processId);
expect(output.success).toBe(true);
Expand All @@ -427,7 +429,7 @@ describe("Background Bash Output Capture", () => {
expect(spawnResult.success).toBe(true);
if (!spawnResult.success) return;

await new Promise((resolve) => setTimeout(resolve, 500));
await waitForProcessExit(manager, spawnResult.processId, PROCESS_EXIT_TIMEOUT_MS);

const output = await manager.getOutput(spawnResult.processId);
expect(output.success).toBe(true);
Expand Down
Loading