fix(vscode-web): point app healthcheck at /version instead of /healthz#923
Open
schnell3526 wants to merge 1 commit into
Open
fix(vscode-web): point app healthcheck at /version instead of /healthz#923schnell3526 wants to merge 1 commit into
schnell3526 wants to merge 1 commit into
Conversation
The standalone VS Code web server exposes no /healthz route (it returns 404; the path was carried over from code-server, which does expose it). The 404 never surfaced because the agent treats any response below 500 as healthy, but the check only verified that something answers HTTP on the port. /version returns 200 in both the subdomain and path-based cases.
da8ea51 to
0ef9483
Compare
matifali
approved these changes
Jun 13, 2026
matifali
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #922.
Summary
The vscode-web module's
coder_apphealthcheck probes/healthz, but Microsoft's standalone VS Code web server exposes no such route — it returns 404 (the path was presumably carried over from the code-server module, where code-server really does serve/healthz). Against the current stable build (1.124.2):The 404 never surfaced in dashboards because the agent treats any response below 500 as healthy (
agent/apphealth.go), but as-is the check only verifies that something answers HTTP on the port, and the URL misleads anyone copying the pattern into their own templates.This switches the healthcheck to
/version, which returns 200 in both the subdomain and path-based branches.Changes
main.tf:healthcheck_urlprobes/versioninstead of/healthzREADME.md: patch version bump via./.github/scripts/version-bump.sh patchFound while building a vscode-web dev container feature (coder/devcontainer-features#22).