feat(coder/github-upload-public-key): support custom key names - #1014
Merged
35C4n0r merged 4 commits intoAug 18, 2026
Conversation
wadefletch
force-pushed
the
codex/configurable-github-key-name
branch
2 times, most recently
from
July 15, 2026 23:18
e8e8934 to
d4185fa
Compare
wadefletch
force-pushed
the
codex/configurable-github-key-name
branch
from
July 15, 2026 23:22
d4185fa to
01959ba
Compare
wadefletch
marked this pull request as ready for review
July 15, 2026 23:25
Collaborator
|
Will review this PR after: #1021 |
Collaborator
|
@wadefletch some minor conflicts in the README, can you resolve and push. |
35C4n0r
enabled auto-merge (squash)
August 18, 2026 10:47
35C4n0r
disabled auto-merge
August 18, 2026 11:15
…custom key name Base64-encode key_name in Terraform and decode it in run.sh so shell metacharacters in a custom title cannot be interpreted or executed when the script is rendered. Build the upload request body with jq so titles containing quotes or backslashes still produce valid JSON. Add a test covering a key name that contains special characters. Generated with Coder Agents.
35C4n0r
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an optional
key_nameinput to thegithub-upload-public-keymodule so templates can give uploaded SSH keys a recognizable GitHub title. Existing users retain the current<Coder access URL> Workspacesdefault.The value follows the module's existing
templatefileand shell interpolation pattern. Tests use the existing fake GitHub server to verify both the default and custom titles sent in the upload request.Type of Change
Module Information
Path:
registry/coder/modules/github-upload-public-keyNew version:
v1.1.0Breaking change: [ ] Yes [x] No
Testing & Validation
bun test) — Docker-backed cases await CI because the local OrbStack daemon is unavailablebun fmt)terraform validate, ShellCheck, and formatting passRelated Issues
None
Generated with Codex using GPT-5.