🤖 fix: use shared settings header tooltips#3665
Open
LeonidasZhak wants to merge 1 commit into
Open
Conversation
Replace native title tooltips in the mobile settings header with the shared tooltip component so the controls use the same portal-backed tooltip behavior as the rest of the app. --- _Generated with `mux` • Model: `GPT-5` • Thinking: `unknown` • Cost: ``_ <!-- mux-attribution: model=GPT-5 thinking=unknown costs=unknown -->
Author
|
@codex review Small cleanup PR replacing the mobile Settings header's native Validation:
|
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the native
titleattributes on the mobile Settings header controls with the sharedTooltipIfPresentcomponent.Background
Mux tooltips should use the shared tooltip system instead of browser-native titles so they portal above clipped containers and avoid duplicate OS/browser tooltip behavior. This keeps the Settings mobile header aligned with that pattern while preserving the existing
aria-labeltext for assistive technology.Validation
./node_modules/.bin/eslint src/browser/features/Settings/SettingsPage.tsx./node_modules/.bin/prettier --check src/browser/features/Settings/SettingsPage.tsx./node_modules/.bin/tsgo --noEmit --project tsconfig.jsongit diff --check origin/main...HEADmake static-checkGenerated with
mux• Model:GPT-5• Thinking:unknown• Cost:$unknown