Make replicaCount optional (skip rendering when null)#7744
Merged
Conversation
egvimo
force-pushed
the
feature/chart
branch
2 times, most recently
from
April 7, 2026 14:02
15504d2 to
8cb687a
Compare
code-asher
approved these changes
Apr 17, 2026
code-asher
left a comment
code-asher
left a comment
Member
There was a problem hiding this comment.
Sorry for the super delayed review, and thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
replicasis always rendered in the Deployment manifest based on.Values.replicaCount, which defaults to1.This makes it impossible to delegate replica management to other mechanisms (e.g., HPA, KEDA) by unsetting the value.
This change allows:
Backward Compatibility
replicaCount: null1) remains unchanged byvalues.yamlNotes
We intentionally avoid a simple
if .Values.replicaCountcheck to ensure0remains a valid value.