Complete Lane G planning acceptance

[mchwang]

Summary

• add G4's composed browser acceptance across productionPlanning, the D-backed createPlanningProvider boundary, F's production HTTP lifecycle and the SQLite Store
• prove suggestions and whole-plan drafts render and Apply in the browser, survive a server restart and remain durable across independent SQLite reopens
• assert the captured provider prompts contain the repository, snapshot base, issue title/body/comment, submitted guidance and persisted r2 plan context
• reconcile T18's original two-agent wording with the later Codex-refusal decision while keeping Lane G/T18 pending on exact-head real-Docker validation

Tracks #145. This is the G4 completion PR.

Done when

npx playwright test test/browser/plans-production.spec.ts && npx vitest run test/planning-provider.test.ts test/planning-production.test.ts test/planning-recorded.test.ts && npm run typecheck passes, and test/agent-planning.test.ts passes on the exact head after the active F5 owner releases heavyweight Docker validation.

Validation

Exact base/head: 89707f86de76ca71060ae0a07496faf084d46088 → d22609c6e9ecaae3f52a0f33829d1908441833ab

• G4 production browser acceptance: 1/1 passed
• full Plans browser surface: 56/56 passed
• complete non-Docker planning backend: 226/226 passed
• focused provider/production/recorded suites on the final head: 57/57 passed
• exact-head real-Docker planning: 1/1 passed in 12.16s
• typecheck: passed
• diff check: passed
• exact-head push CI: passed in 6m37s
• exact-head pull-request CI: passed in 7m10s

Review record

• Author self-review: complete full-diff pass before independent review.
• Independent round 1 on 89707f8..11cf81d: found two valid P2s. The composed test did not assert enough of the captured prompt, and the architecture completion wording conflicted with T18's source checklist.
• Fixes: assert base ref, issue body/comment and persisted r2 context in the provider prompt; record the D: pass the answer schema to both vendors; decide how Codex reads code in read-only phases #75/D: decide how Codex reads code in review, execute and fix (shell is off in every phase) #93 Codex-refusal decision; keep every G/T18 status pending on the one exact-head Docker gate.
• Independent round 2 on 89707f8..23a1798: clean, with both prior findings resolved and no new findings.
• After F5 released Docker ownership, exact-head agent-planning.test.ts passed 1/1; the three source-of-truth status records were changed from pending to complete.
• Independent round 3 on 89707f8..d22609c: clean; both earlier findings remain resolved and the Lane G/T18 completion evidence is consistent.
• Declined findings: none.
• Copilot round 1 on d22609c: approval recommended, 0 open findings; no earlier valid finding remains unresolved.

Review-lesson audit

• The prompt-boundary finding is covered by the existing rule requiring acceptance fixtures to assert the disputed intermediate representation before relying on downstream outcomes.
• The completion-status finding is covered by the existing external-status rule: requested, built, validated and complete remain distinct states.
• No new AGENTS.md/CLAUDE.md rule is needed.

Integration note

PR #149 also edits docs/architecture.md and has already integrated the G3 version from main. Whichever branch integrates second must preserve both F5/F6 status and G4's final Lane G status rather than choosing one side wholesale.

[Copilot]

🟢 Approval recommended

The composed acceptance and supporting documentation consistently satisfy the stated G4 completion criteria.

0 open findings

What changed in this PR

Completes Lane G/T18 planning acceptance across browser, provider, HTTP lifecycle, and durable SQLite storage.

Changes:

• Adds composed production planning browser acceptance.
• Verifies prompt context, schema mounting, restart persistence, and Store reopening.
• Marks G4 and T18 complete with reconciled Codex-refusal documentation.

File	Description
test/​browser/​plans-production.spec.ts	Adds end-to-end production planning acceptance.
docs/​implementation/​planning-screen.md	Documents G4 integration and coverage.
docs/​implementation/​planning-acceptance.md	Records T18 completion evidence.
docs/​designs/​codeboost-plan-indexed-review.md	Updates T18 status and Codex criteria.
docs/​architecture.md	Marks Lane G complete.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.