Add revision-bound plan Apply controls

[mchwang]

Summary

• add revision-bound Apply controls for ready plan drafts and suggestion cards
• retain the exact Apply action ID across ambiguous outcomes and reload only authoritative review state
• preserve newer Review composer text and snippet attachments across Apply
• consume sibling suggestion cards and re-request them against the current revision
• classify unrecorded SQLite failures as retryable 503/outcomeUnknown
• update the planning-screen and architecture status for Lane G3

Tracks #145 (G3 only; G4 remains).

Validation

Exact base/head: c822d360d5098c9f5f36347e00e5949708a5bf96 → e3697dd532643de0f831b678856b2d677338231d

• npm run typecheck — passed
• npx vitest run test/planning-drafts-api.test.ts test/planning-drafts.test.ts test/planning-acceptance.test.ts test/planning-suggestions.test.ts test/planning-author.test.ts test/planning-production.test.ts test/runner-planning-feedback.test.ts — 158 passed
• npx playwright test test/browser/plans.spec.ts test/browser/plans-authoring.spec.ts — 55 passed
• git diff --check — passed

The full repository suite, CI, and real-Docker gate are separate gates. Real-Docker was not started here because PR #149 owns the repository's current heavyweight Docker validation.

Review record

• Self-review: full diff reviewed before the first independent pass; added expected-revision validation and causal wrong-revision coverage.
• Independent round 1, exact c822d36..efebae4: found three valid P2s. Fixed stale authoring after committed Apply/reload failure, terminal Apply focus loss, and retry-key loss when unrecorded SQLite failures were returned as ordinary 409s. Added browser and API regressions.
• Independent round 2, exact c822d36..a30fe1c: prior findings resolved; found one valid P2 where exact revision equality blocked authoring after a later authoritative revision. Changed the proof to monotonic current >= applied and added causal r2→r3 recovery coverage.
• Independent round 3, exact c822d36..662970d: clean; no new findings and no earlier valid findings unresolved.
• Copilot round 1, exact c822d36..662970d: one valid finding. The automatic authoritative reload required exact equality and rejected a concurrent later revision. Changed it to accept any revision at or beyond the committed Apply revision and added causal automatic r2→r3 coverage.
• Independent round 4, exact c822d36..784a083: clean; Copilot's finding and every earlier finding resolved.
• Copilot round 2, exact c822d36..784a083: approval recommended with 0 open findings; its summary noted one valid non-blocking grammar correction in the architecture status.
• Independent round 5, exact c822d36..3462902: clean after correcting that wording; all earlier findings remain resolved.
• Copilot round 3, exact c822d36..3462902: 0 open findings; its summary identified one valid interaction concern where Apply silently ignored activation during conflicting in-flight work.
• Independent round 6, exact c822d36..e3697dd: clean after adding explicit wait feedback and a causal held-refresh regression; all earlier findings remain resolved.
• Copilot round 4, exact c822d36..e3697dd: approval recommended with 0 open findings and no unresolved correctness issues.
• Declined findings: none.

Review-lesson audit

• Stale authoring after an unobserved Apply is covered by the existing async-state/current-response and coupled-lifecycle rules.
• Apply focus restoration is covered by the existing focused-control rule in Async review UI.
• Retriable storage outcomes retaining their idempotency key are covered by the existing resendable storage-error and definite-outcome rules.
• Accepting a later authoritative revision is covered by the existing current-state/generation rules; exact equality was the bug, not a missing operating rule.

No new AGENTS.md/CLAUDE.md rule is needed.

Integration note

PR #149 also edits docs/architecture.md. This branch owns the Lane G/browser-planning statements only; whichever branch integrates second must preserve both its F5 updates and these G3 updates rather than choosing one side wholesale.

[Copilot]

🟡 Changes recommended

The automatic reload rejects valid later authoritative revisions, leaving the UI unnecessarily stale.

1 open finding

• Accept newer revisions when confirming Apply completion · New

What changed in this PR

Adds revision-bound Apply controls for plan drafts and suggestion cards while preserving in-progress review input.

Changes:

• Adds idempotent Apply and suggestion-refresh workflows.
• Classifies SQLite failures as retryable unknown outcomes.
• Adds browser/API regressions and updates Lane G3 documentation.

File	Description
web/​server.ts	Returns retryable SQLite errors.
web/​public/​app.js	Implements Apply workflows and state handling.
web/​public/​style.css	Styles new Apply controls.
test/​planning-drafts-api.test.ts	Tests storage-error replay.
test/​browser/​plans-authoring.spec.ts	Tests Apply behavior and races.
docs/​implementation/​planning-screen.md	Documents G3 behavior.
docs/​architecture.md	Updates planning-screen status.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟢 Approval recommended

The revision and retry behavior is well guarded and tested; only a non-blocking documentation grammar correction remains.

0 open findings

1 resolved since last review

• Accept newer revisions when confirming Apply completion

Previously missed (1)

In code that hasn't changed since last review

Clarify revision binding in status wording

docs/​architecture.md:183

“revision-bound” cannot modify the verb “applies.” Rephrase this status so the revision binding is attached to the results or application process.

🧠 Review effort: Balanced

[Copilot]

🔵 Needs a closer look

Apply silently ignores activation during conflicting in-flight operations while appearing available.

0 open findings

Previously missed (1)

In code that hasn't changed since last review

Show feedback when Apply is clicked during an in-flight operation

web/​public/​app.js:1361

The Apply button remains visually active while a plan refresh/import or another review write is in flight, but this guard silently drops the click. Users receive no indication that Apply did not run. Handle the conflicting-operation branch like startPlanAuthor: keep the safety guard, but show an explicit wait message (or rerender the button as aria-disabled).

🧠 Review effort: Balanced

[Copilot]

🟢 Approval recommended

The implementation is revision-guarded, thoroughly regression-tested, and has no unresolved correctness issues.

0 open findings

🧠 Review effort: Balanced