Repository navigation
F: publish only ledger-recorded commits (snapshot head may hold others) #113
Description
Why
From the #103 review (PR #110). The publisher pushes snapshot.head, and for a review the snapshot head can come from the user's checkout (runner/review.ts). GitBranchPusher only checks that the remote branch's current commit is ledger-owned, before it overwrites the branch. It does not check the commits being pushed. So commits the ledger does not record can reach the codeboost/ branch and the PR. These could be the user's own local commits, or an unrelated commit like the demo's "Unrelated diagnostic output". Otherwise, the push fails with "the runner repository has no commit".
This overlaps #22: rebasing writes foreign ledger entries. When #22 lands, ownedCommits must also be revisited (finding 4 of the #101 review).
Needed
- Decide which head a task publishes: the runner's last commit, or the snapshot head checked against the ledger.
- Before pushing, refuse a head whose
base..headrange holds a commit the ledger does not record asowned, unless a person accepted it. - Do this together with Add pre-merge rebase and head-bound command checks #22's ledger mapping.
Tests
- A snapshot head with a commit the ledger does not record: the publish is refused before any push, and its message names the commit.
- After a rebase (Add pre-merge rebase and head-bound command checks #22): the mapped commits publish.
🤖 Generated with Claude Code
Activity
mchwang commentedon Oct 4, 2026
Decision, made 2026-10-03: keep publishing the whole task head, as the design intends. Implemented in PR #119, which is stacked on #110.
base..HEAD), which the review records before the runner makes its first commit. Then the runner's commits on top.pull-request-opening.md.ownedCommitsonce rebasing writes foreign ledger entries.One gap found along the way and left for a separate follow-up: the merge gate inspects and merges
github.pullRequest, not the task's published PR.This issue closes when PR #119 reaches
main.F: test and document that a published head carries the branch's own c…
F: give the #113 merge-gate test the PR number and draft flag (#121)
F: keep the review's blockers when no merge target resolves; test the…
F: merge the task's published PR, not github.pullRequest (#121) (#126)