fix(scene): report whether animation mutations record undo history - #828
Closed
knoxHuang wants to merge 1 commit into
Closed
fix(scene): report whether animation mutations record undo history#828knoxHuang wants to merge 1 commit into
knoxHuang wants to merge 1 commit into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Background
Successful animation operations do not always push an animation-scoped Undo entry. Without the scene-process outcome, a following Undo or Redo can be routed as though a new history entry exists and consume older history.
✨ Changes
undoRecordedonly when the animation clip snapshot changes and an Undo command is pushed.💡 Design Notes
The scene process is the source of truth for Undo history creation. Consumers use the explicit outcome instead of inferring it from operation success.
🧪 QA Steps
N/A — this is a Cocos CLI scene-process contract. Product validation is performed through the PinK Animation Editor integration flow.
jestis not installed; source test execution remains pending in a dependency-complete CLI checkout.