Skip to content

fix: sync architecture record assets after raster-SVG to PNG conversion (scripts/import-architectures.mjs) #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrbobbytables merged 1 commit into from
Sep 21, 2026
Merged

fix: sync architecture record assets after raster-SVG to PNG conversion (scripts/import-architectures.mjs) #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions scripts/import-architectures.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
writeFileSync,
} from 'node:fs';
import { execFileSync } from 'node:child_process';
import { join, relative } from 'node:path';
import { basename, join, relative } from 'node:path';
import { tmpdir } from 'node:os';
import { parse as yamlParse } from 'yaml';

Expand Down Expand Up @@ -97,14 +97,36 @@ async function importArchitecture(id, commit) {
const destination = join(assetsDir, id, relative(imageDir, file));
mkdirSync(join(destination, '..'), { recursive: true });
cpSync(file, destination);
record.assets.push(
`/img/architectures/${id}/${relative(imageDir, file).replaceAll('\\', '/')}`,
);
}
}
sanitizeArchitectureAssets(join(assetsDir, id));
// Sanitization may convert raster-embedded SVGs to PNG and delete the
// originals, so capture SVG names beforehand and rebuild the asset list
// from disk afterward rather than trusting the copy-time list.
const archAssetsDir = join(assetsDir, id);
const svgsBefore = existsSync(archAssetsDir)
? walkFiles(archAssetsDir).filter((file) => file.endsWith('.svg'))
: [];
sanitizeArchitectureAssets(archAssetsDir);
record.assets = existsSync(archAssetsDir)
? walkFiles(archAssetsDir).map(
(file) =>
`/img/architectures/${id}/${relative(archAssetsDir, file).replaceAll('\\', '/')}`,
)
: [];
const convertedToPng = svgsBefore
.filter(
(file) =>
!existsSync(file) && existsSync(file.replace(/\.svg$/i, '.png')),
)
.map((file) => basename(file));
await mirrorProjectAssets(body);
const cleanBody = cleanMarkdown(renderProjectCards(body, id), id);
let cleanBody = cleanMarkdown(renderProjectCards(body, id), id);
for (const svgName of convertedToPng) {
cleanBody = cleanBody.replaceAll(
`/img/architectures/${id}/${svgName}`,
`/img/architectures/${id}/${svgName.replace(/\.svg$/i, '.png')}`,
);
}
record.summary = firstParagraph(cleanBody);
writeFileSync(
join(recordsDir, `${id}.json`),
Expand Down
Loading