fix: make check:markdown pass on a clean checkout - #315
Open
kubestellar-hive[bot] wants to merge 1 commit into
Open
kubestellar-hive[bot] wants to merge 1 commit into
kubestellar-hive[bot] wants to merge 1 commit into
Conversation
- LAUNCH.md: normalize table pipe spacing (MD060)
- MILESTONES.md, MAINTAINERS.md: rewrap paragraphs so wrapped lines no
longer start with '#', which markdownlint misparsed as ATX headings
(MD018 false positive)
- blog: write the truncate marker as {/*truncate*/}; the spaced form
tripped MD037 (spaces inside emphasis markers). The Docusaurus
truncate regex allows zero whitespace, so truncation still works.
- docs/community/end-user-community.md: drop single trailing space
- add .markdownlintignore for docs/architectures/**: these files are
deleted and regenerated from upstream content by
scripts/import-architectures.mjs on every daily import run, so
hand-applied lint fixes there would be overwritten. Generated pages
remain covered by scripts/validate-architectures.mjs.
Verified: 'npm run check:markdown' exits 0 (was 123, 164 errors in 11
files) and 'npm run test:unit' passes on main @ 00b44df.
Closes #306
Signed-off-by: kubestellar-hive[bot] <kubestellar-hive[bot]@users.noreply.github.com>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "ci-maintainer" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Fix
npm run check:markdownfails on a clean main checkout (exit 123, 164 markdownlint errors in 11 files), which abortsnpm run check/npm test. This PR makes it pass. Verified locally on main @ 00b44df:check:markdownexits 0 andnpm run test:unitpasses.What changes:
#, which markdownlint misparsed as ATX headings (MD018 false positive; running--fixalone made these worse by converting them into real headings){/*truncate*/}; the spaced form{/* truncate */}tripped MD037 (spaces inside emphasis markers). Docusaurus's truncate regex (/<!--\s*truncate\s*-->|\{\/\*\s*truncate\s*\*\/\}/in plugin-content-blog/lib/options.js) allows zero whitespace, so truncation still works.docs/architectures/**. Those 5 files account for the remaining errors, butscripts/import-architectures.mjsdeletes and regenerates them from upstream content on every daily import run, so hand-applied lint fixes would be overwritten. Generated pages stay covered byscripts/validate-architectures.mjs. If the project would rather lint generated content, the fix belongs in the import generator, which is occupied by open PRs (fix: rewrite SVG asset references to PNG after raster-embedded conversion #242, fix(scripts): record post-conversion asset paths in import-architectures #261, [quality] test: cover scripts/import-architectures.mjs offline (tests/helpers-import-sandbox.mjs + tests/import-architectures.test.mjs) #216).Scope note: this touches content files only — no workflows, no src/, no scripts/.
Closes #306
Filed by ci-maintainer agent (ACMM L4/L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=ci-maintainer backend=copilot model=kimi-k3