fix: rewire check:links off missing Makefile and drop orphan typecheck script - #291
Open
kubestellar-hive[bot] wants to merge 1 commit into
Open
kubestellar-hive[bot] wants to merge 1 commit into
kubestellar-hive[bot] wants to merge 1 commit into
Conversation
![kubestellar-hive[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…k script _check:links invoked 'make --keep-going check-links', but the repo has no Makefile (none ever existed), so check:links failed with exit 127 and took down 'npm run check' and 'npm test' on a clean checkout. The make target was the htmltest indirection from the site template; htmltest is not a dependency here, so _check:links:internal and precheck:links (a full site build that only existed to feed htmltest) were dead weight. Point _check:links at the working _check:links-md script directly. Also drop 'typecheck: tsc': the repo has no tsconfig.json and no TypeScript sources, so the script could never pass. Verified on a clean checkout: check:links now executes markdown-link-check and reports actionable dead links instead of 'make: command not found'; test:unit passes (55/55). Signed-off-by: kubestellar-hive[bot] <kubestellar-hive@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "ci-maintainer" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Fix
npm run check(and thereforenpm test) aborts on a clean checkout because of two dead script wirings inpackage.json:check:links->make check-links(exit 127)._check:linksinvokedmake --keep-going check-links, but the repository has no Makefile (none ever existed). The make target was the htmltest indirection inherited from the site template, and htmltest is not a dependency here, so_check:links:internalandprecheck:links(a full site build that existed only to feed htmltest) were dead weight._check:linksnow points directly at the working_check:links-mdscript;_check:links:internalandprecheck:linksare removed.typecheck: tsc(always fails). The repo has notsconfig.jsonand no TypeScript sources, so baretsccan never pass. Script removed.Scope note: this PR fixes the wiring only. With the wiring fixed,
check:linksruns and reports two real dead links (https://www.npmjs.com/-> 403 bot-block,https://endusers.cncf.io/-> 502, tracked in #171);check:format,check:spelling, andcheck:markdownalso still fail on content issues tracked by #264. Those are deliberately left to their own issues.Files claimed:
package.json(scriptssection only —_check:links,_check:links:internal,precheck:links,typecheck). No overlap with open PRs touchingpackage.jsonoverrides(#191) or the script-wiring tests in #278 (tests/workflow-scripts.test.mjs).Verification
00b44df:check:linkspreviously exited 127 (make: command not found); now executesmarkdown-link-checkand exits 1 with actionable dead-link outputnpm run test:unit— 55/55 passingpython3 -m json.tool package.json— validCloses #283
Closes #284
Filed by ci-maintainer agent (ACMM L4/L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=ci-maintainer backend=copilot model=kimi-k3