fix(config): point editUrl at cncf/endusers, not castrojo - #245
Open
mrbobbytables wants to merge 1 commit into
Open
mrbobbytables wants to merge 1 commit into
mrbobbytables wants to merge 1 commit into
Conversation
The repo was transferred from castrojo/endusers to cncf/endusers. Update docusaurus.config.js's docs and blog editUrl values (and the inline SITE_URL example comment) to point at the cncf org instead of the stale castrojo org. Note: .github/workflows/deploy-gh-pages.yml's SITE_URL env var also still points at https://castrojo.github.io (which now 404s after the org transfer, breaking sitemap.xml, canonical, and og/twitter URLs on the live site) and needs the same fix, but this automated change cannot push to files under .github/workflows/ (requires the 'workflow' OAuth scope, which this token lacks). A maintainer with that scope should change SITE_URL to https://cncf.github.io. Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes part of #232. After the repo transfer from
castrojo/enduserstocncf/endusers, several hard-coded URLs still pointed at the oldcastrojoorg:docusaurus.config.js: botheditUrlvalues ("Edit this page" links) for docs and blog now point athttps://github.com/cncf/endusers/tree/main(and.../main/), instead of the stalecastrojoorg.SITE_URL/BASE_URLoverrides to reference the correct org too.Known remaining gap — needs a maintainer with
workflowscope.github/workflows/deploy-gh-pages.ymlstill builds the site with:https://castrojo.github.io/endusers/now 404s since the org transfer; the live site is actually served athttps://cncf.github.io/endusers/. BecauseSITE_URLis stale, every absolute URL Docusaurus emits (sitemap.xml<loc>,og:url,og:image,twitter:image, hreflang alternates, canonical links) points at the broken origin — this is the core problem reported in #232.This PR does not include that fix. The automated token used to push this branch lacks the
workflowOAuth scope, and GitHub rejects any push that touches files under.github/workflows/without it:A maintainer (or a token with
workflowscope) needs to apply this one-line change separately:- name: Build website env: - SITE_URL: https://castrojo.github.io + SITE_URL: https://cncf.github.io BASE_URL: /endusers/(Note: PR #167 also contains this
SITE_URLfix but is currentlyCONFLICTINGand bundles it with unrelated ADR/README rewrites, per the issue notes.)Verification
grep -rn castrojo docusaurus.config.js→ no matches after this change.https://castrojo.github.io/endusers/→ 404,https://cncf.github.io/endusers/→ 200.— hive: backend=copilot
🐝 Hive Agent:
contributor| SHA:eb3efc3