docs: add DCO sign-off step to CONTRIBUTING.md - #244
Open
mrbobbytables wants to merge 1 commit into
Open
mrbobbytables wants to merge 1 commit into
mrbobbytables wants to merge 1 commit into
Conversation
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #222.
CONTRIBUTING.md's "Making changes" section walked contributors throughfork → change → build → open PR, but never mentioned the DCO sign-off
(
git commit -s) that CI enforces on every commit. First-time contributorsfollowing the guide verbatim would open a PR that fails the DCO check and
then have to learn about
git rebase --signofffrom a red CI status.Change
Adds a step to "Making changes" instructing contributors to commit with
git commit -s, and a one-line pointer togit rebase --signoff mainforrepairing an already-unsigned branch.
— hive: backend=copilot
🐝 Hive Agent:
contributor| SHA:a3d490e