Skip to content

fix(greenhouse): fix typos and spacing in Plugin and Cluster#1734

Merged
guoda-puidokaite merged 7 commits into
mainfrom
guoda-plugin-view-typos
Jun 1, 2026
Merged

fix(greenhouse): fix typos and spacing in Plugin and Cluster#1734
guoda-puidokaite merged 7 commits into
mainfrom
guoda-plugin-view-typos

Conversation

@guoda-puidokaite
Copy link
Copy Markdown
Contributor

@guoda-puidokaite guoda-puidokaite commented Jun 1, 2026 •
edited
Loading

Summary

See ACs.

Related Issues

Fixes #1606 and #1605

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@guoda-puidokaite
fix plugin definition name
275245d 
Signed-off-by: I531348 <guoda.puidokaite@sap.com>
@guoda-puidokaite guoda-puidokaite self-assigned this Jun 1, 2026
Copilot AI review requested due to automatic review settings June 1, 2026 04:50
@guoda-puidokaite guoda-puidokaite added the package All tasks related to package under packages/ label Jun 1, 2026
@guoda-puidokaite guoda-puidokaite requested a review from a team as a code owner June 1, 2026 04:50
@guoda-puidokaite guoda-puidokaite added the ui-components All tasks related to juno-ui-components library label Jun 1, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 1, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 0005cb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-app-greenhouse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI reviewed Jun 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@guoda-puidokaite guoda-puidokaite linked an issue Jun 1, 2026 that may be closed by this pull request
[Bug](greenhouse): Typos in PluginPreset view #1605
Closed
@guoda-puidokaite
fix typos
df3201e 
Signed-off-by: I531348 <guoda.puidokaite@sap.com>
guoda-puidokaite
guoda-puidokaite commented Jun 1, 2026
View reviewed changes
Comment thread apps/greenhouse/src/components/admin/api/plugin-presets/fetchPluginPresetsFilters.ts Outdated
@guoda-puidokaite
fix space and changeset
0884194 
Signed-off-by: I531348 <guoda.puidokaite@sap.com>
@guoda-puidokaite guoda-puidokaite linked an issue Jun 1, 2026 that may be closed by this pull request
[Bug](greenhouse): Spacing of PluginPreset vs Plugin view #1601
Closed
@guoda-puidokaite guoda-puidokaite added greenhouse Greenhouse core related task app Any app that is not specific label that lives under apps/ greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview` and removed package All tasks related to package under packages/ ui-components All tasks related to juno-ui-components library labels Jun 1, 2026
@guoda-puidokaite guoda-puidokaite changed the title fix(greenhouse): fix plugin definition name fix(greenhouse): fix typos and spacing Jun 1, 2026
@guoda-puidokaite guoda-puidokaite changed the title fix(greenhouse): fix typos and spacing fix(greenhouse): fix typos and spacing in Plugin and Cluster Jun 1, 2026
@guoda-puidokaite
fix filter name
63cb248 
Signed-off-by: I531348 <guoda.puidokaite@sap.com>
@github-actions github-actions Bot added greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. and removed greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. labels Jun 1, 2026
ArtieReus
ArtieReus requested changes Jun 1, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ArtieReus ArtieReus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing one the typo below

@ArtieReus
Copy link
Copy Markdown
Collaborator

ArtieReus commented Jun 1, 2026

This isnt fixed yet...
Screenshot 2026-06-01 at 12 42 23

@github-actions github-actions Bot added greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. and removed greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. labels Jun 1, 2026
@guoda-puidokaite
fix typo
4734388 
Signed-off-by: I531348 <guoda.puidokaite@sap.com>
@github-actions github-actions Bot added greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. and removed greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. labels Jun 1, 2026
ArtieReus
ArtieReus previously approved these changes Jun 1, 2026
View reviewed changes
TilmanHaupt
TilmanHaupt previously approved these changes Jun 1, 2026
View reviewed changes
edda
edda previously approved these changes Jun 1, 2026
View reviewed changes
@guoda-puidokaite
merge main
0005cb8 
Signed-off-by: I531348 <guoda.puidokaite@sap.com>
@guoda-puidokaite guoda-puidokaite dismissed stale reviews from edda, TilmanHaupt, and ArtieReus via 0005cb8 June 1, 2026 13:12
@github-actions github-actions Bot added greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. and removed greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. labels Jun 1, 2026
@guoda-puidokaite guoda-puidokaite merged commit 85d915e into main Jun 1, 2026
22 checks passed
@guoda-puidokaite guoda-puidokaite deleted the guoda-plugin-view-typos branch June 1, 2026 13:33
@github-actions github-actions Bot removed the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ArtieReus ArtieReus ArtieReus approved these changes

@TilmanHaupt TilmanHaupt TilmanHaupt approved these changes

@edda edda edda left review comments

Assignees

@guoda-puidokaite guoda-puidokaite

Labels

app Any app that is not specific label that lives under apps/ greenhouse Greenhouse core related task greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview`

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug](greenhouse): Typos in Plugin view [Bug](greenhouse): Typos in PluginPreset view [Bug](greenhouse): Spacing of PluginPreset vs Plugin view

5 participants

@guoda-puidokaite @ArtieReus @edda @TilmanHaupt