Conversation
dosubot
Bot
added
the
size:XS
NiccoloFei
approved these changes
Jun 23, 2026
litaocdl
approved these changes
Jun 24, 2026
mnencia
approved these changes
Jul 9, 2026
Recreate the parallel WAL-restore coverage in the plugin repo: a 2-instance cluster archiving to minio with wal.maxParallel=3, forged WAL segments on the object store, and assertions on the plugin's prefetch/spool/end-of-wal-stream state machine driven through `/controller/manager wal-restore` on the standby. Part of cloudnative-pg/cloudnative-pg#10954. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
If pod-1 is not the primary we'd fail anyway because a timeline bump would make all assertions about the walLogDir fail. Also there's no reason why there should have been a switchover, so we should not hide a failure if that happens. Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Every other e2e fixture pins its image by digest with a companion Version comment; the s3-client image was the only one still pinned by a mutable tag. Note this doesn't yet restore renovate parity with those fixtures: renovate.json5's ignorePaths still excludes anything under test/e2e/internal/tests/**, which is where every Ginkgo test package in this suite (including this one) lives, so the digest won't be bumped automatically until that gap is closed separately. The digest pin is still worth having on its own for reproducibility. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Assert the actual exit code on the end-of-wal-stream fast-fail path instead of just HaveOccurred(), which would pass for any error. Also correct a comment claiming ExecuteInContainer folds command output into the returned error; it only carries the exit code, so forging a WAL segment fails with no indication of the underlying aws CLI error. Drop an unnecessary var declaration and note the real bound on the forged segment numbering. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreate the parallel WAL-restore coverage in the plugin repo: a 2-instance cluster archiving to minio with wal.maxParallel=3, forged WAL segments on the object store, and assertions on the plugin's prefetch/spool/end-of-wal-stream state machine driven through
/controller/manager wal-restoreon the standby.Part of cloudnative-pg/cloudnative-pg#10954.