[vite-plugin] Close disabled HMR WebSocket upgrades - #15290
Open
edmundhung wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: b526abf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
|
@edmundhung Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
Contributor
|
✅ All changesets look good |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
edmundhung
force-pushed
the
edmundhung/fix-vite-disabled-websocket
branch
2 times, most recently
from
August 20, 2026 18:45
3472681 to
dcd5dd7
Compare
edmundhung
force-pushed
the
edmundhung/fix-vite-disabled-websocket
branch
from
August 21, 2026 16:59
dcd5dd7 to
b526abf
Compare
edmundhung
marked this pull request as ready for review
August 21, 2026 17:20
workers-devprod
requested review from
a team and
penalosa
and removed request for
a team
August 21, 2026 17:20
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15285.
Close Vite HMR upgrade sockets when
server.wsis disabled and no Vite WebSocket handler can claim them. Continue delegating requests to Vite when enabled, while preserving Worker and Sandbox WebSocket forwarding.server.ws: falsebehavior and adds no new user-facing API.A picture of a cute animal (not mandatory, but encouraged)