Skip to content

Use simdutf for remaining base64 decodes#6847

Open
Brooooooklyn wants to merge 2 commits into
cloudflare:mainfrom
Brooooooklyn:optimize-simd-base64-decode
Open

Use simdutf for remaining base64 decodes#6847
Brooooooklyn wants to merge 2 commits into
cloudflare:mainfrom
Brooooooklyn:optimize-simd-base64-decode

Conversation

@Brooooooklyn

@Brooooooklyn Brooooooklyn commented Jun 29, 2026

Copy link
Copy Markdown
Member

Summary:

  • Replace global atob() decoding with simdutf::base64_to_binary while preserving the existing InvalidCharacterError behavior.
  • Replace DataUrl's KJ base64 decode with a compatibility-preserving base64 alphabet filter followed by simdutf decoding.
  • Update the data-url Bazel target to depend directly on @simdutf and drop the unused encoding implementation dependency.

@Brooooooklyn Brooooooklyn requested review from a team as code owners June 29, 2026 09:38
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Brooooooklyn Brooooooklyn force-pushed the optimize-simd-base64-decode branch from 7f2d2c7 to f7585ee Compare June 29, 2026 12:54
@Brooooooklyn Brooooooklyn force-pushed the optimize-simd-base64-decode branch from f7585ee to 90620d3 Compare July 3, 2026 10:14
@codspeed-hq

codspeed-hq Bot commented Jul 3, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 129 skipped benchmarks1


Comparing Brooooooklyn:optimize-simd-base64-decode (40c9392) with main (1bdc662)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Brooooooklyn

Copy link
Copy Markdown
Member Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Jul 3, 2026
@Brooooooklyn Brooooooklyn reopened this Jul 3, 2026

@anonrig anonrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants