Surface batch-apply consequences in the action UI - #242
Draft
ndisidore wants to merge 3 commits into
Draft
Conversation
|
@ndisidore Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
ndisidore
force-pushed
the
nathan/action-apply-ui
branch
from
August 17, 2026 21:15
9e91e22 to
374ed24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #241. Phase-1 frontend stopgap for the batch
applyActionsThroughsemantics — RPC signatures are unchanged (approveAction(id)/rejectAction(id); the frontier semantics live behindapproveAction), which is what keeps Phase 2's batch-review UI a UI-only change.countEarlierPending).failure: when a batch pass stops at an action, its pending card shows the gatekeeper's display-safe reason (Activity review card, chat inline row and blocking callout). The existinguseResolveActionfailure toast is unchanged.cascadedFrom: rejected entries invalidated by another action's veto show "Invalidated by rejection of '{title}'" (title from the local list, generic fallback) in the Activity history details and the chat card's expanded view.Optimistic resolve state is untouched — batch-decided sibling records arrive via the
subscribeToActionssubscription.Tested with
pnpm build,pnpm test,pnpm lint:check.