Skip to content

Surface batch-apply consequences in the action UI - #242

Draft
ndisidore wants to merge 3 commits into
nathan/action-sync-driverfrom
nathan/action-apply-ui
Draft

Surface batch-apply consequences in the action UI#242
ndisidore wants to merge 3 commits into
nathan/action-sync-driverfrom
nathan/action-apply-ui

Conversation

@ndisidore

Copy link
Copy Markdown
Contributor

Stacked on #241. Phase-1 frontend stopgap for the batch applyActionsThrough semantics — RPC signatures are unchanged (approveAction(id) / rejectAction(id); the frontier semantics live behind approveAction), which is what keeps Phase 2's batch-review UI a UI-only change.

  • "+N earlier" hint on Approve buttons (Activity review pane, chat action cards, header notifications popover): approving an action now also applies every earlier pending action from the same gatekeeper connection, so the button says so. Count comes from the already-subscribed local action list (countEarlierPending).
  • failure: when a batch pass stops at an action, its pending card shows the gatekeeper's display-safe reason (Activity review card, chat inline row and blocking callout). The existing useResolveAction failure toast is unchanged.
  • cascadedFrom: rejected entries invalidated by another action's veto show "Invalidated by rejection of '{title}'" (title from the local list, generic fallback) in the Activity history details and the chat card's expanded view.

Optimistic resolve state is untouched — batch-decided sibling records arrive via the subscribeToActions subscription.

Tested with pnpm build, pnpm test, pnpm lint:check.

@github-actions github-actions Bot added the workshop/frontend Changes to the Workshop frontend label Aug 17, 2026
@ask-bonk

ask-bonk Bot commented Aug 17, 2026

Copy link
Copy Markdown

github run

@ask-bonk

ask-bonk Bot commented Aug 17, 2026

Copy link
Copy Markdown

@ndisidore Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@ndisidore
ndisidore force-pushed the nathan/action-apply-ui branch from 9e91e22 to 374ed24 Compare August 17, 2026 21:15
@ask-bonk

ask-bonk Bot commented Aug 17, 2026

Copy link
Copy Markdown

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workshop/frontend Changes to the Workshop frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant