Skip to content

Fix overlapping note text in SASE diagram caption - #32829

Merged
nikitacano merged 1 commit into
cloudflare:productionfrom
hugo-vicente11:fix/sase-diagram-caption-overlap
Aug 18, 2026
Merged

Fix overlapping note text in SASE diagram caption#32829
nikitacano merged 1 commit into
cloudflare:productionfrom
hugo-vicente11:fix/sase-diagram-caption-overlap

Conversation

@hugo-vicente11

Copy link
Copy Markdown
Contributor

Summary

Fixes overlapping caption text under the network architecture diagram in the SASE reference architecture page. The second "Note" was wrapped in a malformed multi-line <sub> block, which caused it to render on top of the preceding note instead of as a separate paragraph. Converted it to a standard italic note paragraph, consistent with the rest of the docs.
No changelog entry needed (typo/rendering fix), no new page, and no files were renamed, so the rest of the checklist items don't apply here.

Screenshots

Before:

Screenshot 2026-08-18 at 17 12 41

After:

Screenshot 2026-08-18 at 17 13 19

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning found in commit 99f9140.

👉 Fix in your agent 👈
Fix the following review findings in PR #32829 (https://github.com/cloudflare/cloudflare-docs/pull/32829).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Style Guide Review

### Warnings (1)

#### SG-b0d596ac1c73 · Monospace IP addresses
- **File:** `src/content/docs/reference-architecture/architectures/sase.mdx` line 345
- **Issue:** Line contains `100.96.0.0/12` in plain prose
- **Fix:** Wrap the CIDR in backticks: `100.96.0.0/12`

Code Review

This code review is in beta and may not always be helpful — use your judgment.

No code review issues found.

Conventions

No convention issues found.

Style Guide Review

Warnings (1)
File Issue
reference-architecture/architectures/sase.mdx line 345 Monospace IP addresses — Line contains 100.96.0.0/12 in plain prose Fix: Wrap the CIDR in backticks: 100.96.0.0/12
Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a rendering issue on the SASE reference architecture page where a second note under the “Connecting and routing traffic…” diagram was wrapped in a malformed multi-line <sub> block, causing caption text overlap. The change normalizes the note formatting to match surrounding documentation patterns so the caption renders as two separate note paragraphs.

Changes:

  • Removed the malformed multi-line <sub> wrapper around the second note under the diagram caption.
  • Replaced it with a standard italic “Note: …” paragraph consistent with the adjacent note formatting.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@hugo-vicente11
hugo-vicente11 force-pushed the fix/sase-diagram-caption-overlap branch from 9bf3ad0 to 99f9140 Compare August 18, 2026 16:17
@nikitacano
nikitacano merged commit ec9a673 into cloudflare:production Aug 18, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants