Skip to content

Update PII categories for AI Security for Apps model migration - #32825

Merged
xmflsct merged 1 commit into
cloudflare:productionfrom
mrusso19:mrusso/update-aisa-pii-docs
Aug 19, 2026
Merged

Update PII categories for AI Security for Apps model migration#32825
xmflsct merged 1 commit into
cloudflare:productionfrom
mrusso19:mrusso/update-aisa-pii-docs

Conversation

@mrusso19

Copy link
Copy Markdown
Contributor

Summary

Updates public documentation to reflect the PII detection model migration from Presidio to a new AI-based Named Entity Recognition (NER) model.

Replace the 39 Presidio-based PII categories with 13 categories supported by the new NER model. Remove Presidio attribution from docs; update example rules to use BANK_ACCOUNT instead of dropped IBAN_CODE/US_BANK_NUMBER.

Screenshots (optional)

Documentation checklist

  • Is there a changelog entry (guidelines)? If you don't add one for something awesome and new (however small) — how will our customers find out? Changelogs are automatically posted to RSS feeds, the Discord, and X.
  • The change adheres to the documentation style guide.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning found in commit 2491b4e.

👉 Fix in your agent 👈
Fix the following review findings in PR #32825 (https://github.com/cloudflare/cloudflare-docs/pull/32825).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Code Review

### Warnings (1)

#### CR-118ecf525262 · Category list out of sync with field reference
- **File:** `src/content/docs/waf/detections/ai-security-for-apps/pii-detection.mdx` line 30
- **Issue:** Line 30 points readers to the `cf.llm.prompt.pii_categories` field reference for the full list of categories. The current `src/content/fields/index.yaml` still enumerates the old set (`CRYPTO`, `US_BANK_NUMBER`, `IBAN_CODE`, `US_DRIVER_LICENSE`, `US_ITIN`, `US_PASSPORT`, `NRP`, `UK_NHS`, `UK_NINO`, `ES_NIF`), which does not match the migrated categories shown in the new table. Unless the field reference is also updated, the two pages will contradict each other.
- **Fix:** Update the `cf.llm.prompt.pii_categories` field reference (in `src/content/fields/index.yaml` or the generated page) to the same migrated category set so the linked reference and this table stay consistent.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Warnings (1)
File Issue
waf/detections/ai-security-for-apps/pii-detection.mdx line 30 Category list out of sync with field reference — Line 30 points readers to the cf.llm.prompt.pii_categories field reference for the full list of categories. The current src/content/fields/index.yaml still enumerates the old set (CRYPTO, US_BANK_NUMBER, IBAN_CODE, US_DRIVER_LICENSE, US_ITIN, US_PASSPORT, NRP, UK_NHS, UK_NINO, ES_NIF), which does not match the migrated categories shown in the new table. Unless the field reference is also updated, the two pages will contradict each other. Fix: Update the cf.llm.prompt.pii_categories field reference (in src/content/fields/index.yaml or the generated page) to the same migrated category set so the linked reference and this table stay consistent.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@mrusso19
mrusso19 force-pushed the mrusso/update-aisa-pii-docs branch 2 times, most recently from 5febddf to c263eec Compare August 18, 2026 17:32
Replace the 39 Presidio-based PII categories with 13 categories supported
by the new NER model. Remove Presidio attribution from docs; update example
rules to use BANK_ACCOUNT instead of dropped IBAN_CODE/US_BANK_NUMBER.
@mrusso19
mrusso19 force-pushed the mrusso/update-aisa-pii-docs branch from c263eec to 2491b4e Compare August 19, 2026 08:44
@mrusso19

Copy link
Copy Markdown
Contributor Author

Category list out of sync with field reference — Line 30 points readers to the cf.llm.prompt.pii_categories field reference for the full list of categories. The current src/content/fields/index.yaml still enumerates the old set (CRYPTO, US_BANK_NUMBER, IBAN_CODE, US_DRIVER_LICENSE, US_ITIN, US_PASSPORT, NRP, UK_NHS, UK_NINO, ES_NIF), which does not match the migrated categories shown in the new table. Unless the field reference is also updated, the two pages will contradict each other. Fix: Update the cf.llm.prompt.pii_categories field reference (in src/content/fields/index.yaml or the generated page) to the same migrated category set so the linked reference and this table stay consistent.

We are updating src/content/fields/index.yaml in the same PR. This review comment is wrong.

@xmflsct
xmflsct merged commit 0026d94 into cloudflare:production Aug 19, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants