fix: show more docs search results - #32808
Open
dmmulroy wants to merge 1 commit into
Open
Conversation
Contributor
Review
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
dmmulroy
force-pushed
the
fix/artifacts-search-visibility-forkbase
branch
from
August 17, 2026 18:09
a9d0280 to
a72c811
Compare
kodster28
approved these changes
Aug 17, 2026
Collaborator
|
/rebase |
Collaborator
|
@dmmulroy, mind rebasing your branch? Also gave you perms for merging + opening PRs against the repo directly in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Artifacts search visibility in the docs search modal by rendering 15 of the 50 results already returned by AI Search.
The Artifacts landing page is indexed, but for the exact query
Artifactsit currently appears at result position 13. The modal previously rendered only the first 10 results, so/artifacts/was effectively hidden even though the search API returned it.This is a minimal docs-side visibility fix. It does not change AI Search ranking or indexing behavior.
Proof
Animated GIF previews, MP4 recordings, and extracted result lists are linked as durable GitHub-hosted proof assets on a separate proof branch in this fork. They are not committed to this PR branch.
Before:
After:
Full MP4 recordings:
artifacts-search-before.mp4artifacts-search-after.mp4Extracted result lists:
artifacts-search-before.jsonartifacts-search-after.jsonProof summary:
developers.cloudflare.comrenders 10 results forArtifacts;/artifacts/is not visible.Artifacts;/artifacts/is visible at position 13.Validation
Passed:
pnpm run checkpnpm run lintpnpm run format:core:checkpnpm run buildpnpm exec vitest --testTimeout=30000(108/108 tests passed)Note: the default
pnpm run testreached 106 passing tests but two Worker tests timed out at the default 5s limit after build. Re-running the same Vitest suite with--testTimeout=30000passed 108/108.Follow-up
The stronger long-term fix is to improve exact product-name landing-page ranking in the AI Search endpoint/snippet/backend. This PR only prevents returned results ranked 11-15 from being hidden by the modal render cap.