Skip to content

fix: show more docs search results - #32808

Open
dmmulroy wants to merge 1 commit into
cloudflare:productionfrom
dmmulroy:fix/artifacts-search-visibility-forkbase
Open

fix: show more docs search results#32808
dmmulroy wants to merge 1 commit into
cloudflare:productionfrom
dmmulroy:fix/artifacts-search-visibility-forkbase

Conversation

@dmmulroy

@dmmulroy dmmulroy commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes Artifacts search visibility in the docs search modal by rendering 15 of the 50 results already returned by AI Search.

The Artifacts landing page is indexed, but for the exact query Artifacts it currently appears at result position 13. The modal previously rendered only the first 10 results, so /artifacts/ was effectively hidden even though the search API returned it.

This is a minimal docs-side visibility fix. It does not change AI Search ranking or indexing behavior.

Proof

Animated GIF previews, MP4 recordings, and extracted result lists are linked as durable GitHub-hosted proof assets on a separate proof branch in this fork. They are not committed to this PR branch.

Before:

Before: Artifacts landing page is not visible in the rendered top 10 results

After:

After: Artifacts landing page is visible at rendered result position 13

Full MP4 recordings:

Extracted result lists:

Proof summary:

  • Before: production developers.cloudflare.com renders 10 results for Artifacts; /artifacts/ is not visible.
  • After: built local preview renders 15 results for Artifacts; /artifacts/ is visible at position 13.

Validation

Passed:

  • pnpm run check
  • pnpm run lint
  • pnpm run format:core:check
  • pnpm run build
  • pnpm exec vitest --testTimeout=30000 (108/108 tests passed)

Note: the default pnpm run test reached 106 passing tests but two Worker tests timed out at the default 5s limit after build. Re-running the same Vitest suite with --testTimeout=30000 passed 108/108.

Follow-up

The stronger long-term fix is to improve exact product-name landing-page ranking in the AI Search endpoint/snippet/backend. This PR only prevents returned results ranked 11-15 from being hidden by the modal render cap.

@dmmulroy
dmmulroy requested a review from a team as a code owner August 17, 2026 17:48
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ Rebase: Rebase skipped — cannot push to fork branches. The PR author must rebase locally.
✅ No issues found in commit a72c811.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

No code review issues found.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@dmmulroy
dmmulroy force-pushed the fix/artifacts-search-visibility-forkbase branch from a9d0280 to a72c811 Compare August 17, 2026 18:09
@kodster28

Copy link
Copy Markdown
Collaborator

/rebase

@kodster28

Copy link
Copy Markdown
Collaborator

@dmmulroy, mind rebasing your branch?

Also gave you perms for merging + opening PRs against the repo directly in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants