Repository navigation
chore: migrate type checking to tsrs - #374
Conversation
commit: |
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 278.1 ms | 4.0 ms | 270.7 ms | 285.7 ms |
| base | 278.2 ms | 8.7 ms | 269.2 ms | 305.8 ms |
Δ (PR vs base): — -0.0 ms (-0.0%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
|
🤖 I've done a thorough review of your PR. Migrates repository type checking from tsgo to tsrs.
|
|
✅ Approved — This is a clean tooling swap from tsgo to an exact-pinned tsrs, with no runtime code affected and no tsgo or @typescript/native-preview references left outside the lockfile. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed🔒 Security: ✅ LGTMThis change affects only development tooling, with no runtime, auth or secrets impact. 📖 AGENTS.md: ✅ LGTMThe AGENTS.md edits replace tsgo with tsrs consistently across the root and CLI files. The guidance against reintroducing 📋 Code Quality: ✅ LGTMBoth ⚡ Performance: ✅ LGTMThe change only replaces the type-check command and its dependency. It adds no runtime code. 📝 Documentation: ✅ LGTMThe tooling references in Reviewed commit: |
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Looks good to me, with the exception of the windows binary issue which I think should get solved before merging this PR
|
oh, it is kind of nice that in cloudflare/workers-sdk#16384 CI actually became red because of the windows issue, are we missing some windows type-checkings/builds here? 🤔 |
|
If I understand correctly, the concern is only that we can't check types of this monorepo when running in Windows? |
|
LGTM |
@dario-piotrowicz They're working on a windows binary, and in the meantime I think development on this repo not working in Windows is an okay tradeoff |
Yes, I was thinking of the windows support in particular for external contributors that might want to pull down the repo and work on it on windows. That's probably not a huge issue for the time being in any case 👍 |
Switch the CLI, generator plugin, and container fixture type checks from tsgo to pinned
tsrs@0.18.0-ts7.1.0-dev.20260929. Remove@typescript/native-preview, update the lockfile, and refresh tooling references.Validated with
pnpm install --frozen-lockfileandpnpm check.