fix(api): normalize GraphQL HTTP errors - #302
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #293.
Summary
GraphQL
QueryandMutatecalls currently expose the dependency's raw string error for non-2xx responses. This prevents callers from inspecting the HTTP status, response headers, and structured error message consistently with REST andDocalls.Changes
HandleHTTPErrorparser.QueryandMutate.errorsarray.Testing
go test ./pkg/api✅go test ./...✅go test -race ./pkg/api✅go vet ./...✅gofmt -w pkg/api/graphql_client.go pkg/api/graphql_client_test.go✅git diff --check✅Notes
The change reuses the existing
HTTPErrorandHandleHTTPErrorbehavior, so GraphQL and REST callers receive the same structured error type. The implementation was assisted by an AI coding tool and manually reviewed against the repository code and tests.