ci(repo): restore release-triggered TypeDoc sync - #9988
Conversation
🦋 Changeset detectedLatest commit: 275f1b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: This review used your included allowance. 8 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 WalkthroughWalkthroughThe release and recovery workflows now dispatch to Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~12 minutes Suggested reviewers: Merge Risk: 🟡 Moderate · up to Before merging, confirm that clerk/clerk main accepts javascript_ref and that CLERK_COOKIE_PAT can dispatch its workflow. Otherwise a stable release may publish packages while the TypeDoc sync fails and the release job is marked failed. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
| run: | | ||
| npm init --scope=clerk --yes | ||
| npm i --save-dev @commitlint/config-conventional @commitlint/cli globby --audit=false --fund=false | ||
| npm i --save-dev @commitlint/config-conventional @commitlint/cli --audit=false --fund=false |
There was a problem hiding this comment.
@wobsoriano I removed globby from the PR title-linter install because commitlint.config.ts doesn't use it. Its dependency download was returning a 404, causing the job to fail before it checked the PR title. Just wanted to flag in case I'm missing sth here?
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Pushed a change directly in e22a3e9.
|
|
@manovotny I pushed a small documentation follow-up:
|
Important
DO NOT merge this PR before the companion
clerk/clerkPR is merged.Description
After a stable package publish, dispatch
clerk/clerk'sdocs-typedoc.ymlinstead of the retiredclerk/clerk-docsworkflow. Pass the publishing run's JavaScript commit SHA (context.sha) so TypeDoc checks out that exact repository revision. Both the normal and recovery paths mark TypeDoc as critical: its dispatch failure fails the release job visibly, while dispatch failures to dashboard and sdk-infra-workers remain warnings.The contributor guide now links to its current path in the public docs mirror, and
docs/CICD.mdnamesclerk/clerkandclerk-docs/clerk-typedoc/as the TypeDoc destination.Release timing: The release workflow runs on pushes to
main, but the normal TypeDoc dispatch is gated on Changesets reportingpublished == 'true'. A JSDoc-only merge without a package publish does not trigger TypeDoc; its changes are picked up by a later stable publish or a manual TypeDoc run. This matches the old automatic release gate.Release announcement behavior: The TypeDoc dispatch runs before the existing Slack publish announcement. A failed TypeDoc dispatch leaves the Actions run red, but the announcement still sends when Changesets reports a publish, the run has not been canceled, and its payload was built successfully. The
!cancelled()conditions bypass GitHub Actions' implicit success gate after a dispatch failure while respecting cancellation. This preserves the previous publish-announcement behavior; it does not add a TypeDoc Slack alert. The ticket requires a visible dispatch failure, not this announcement behavior.This pairs with clerk/clerk#3474, which must merge first to accept
javascript_ref.CLERK_COOKIE_PATmust have workflow-dispatch access toclerk/clerk; its repository scope still needs verification. The workflow YAML parses, the diff passes whitespace checks, and mocked failures cover every target in both dispatch paths. The end-to-end check is a production release opening a TypeDoc PR without manual dispatch.An empty changeset is included because this is a repository workflow change with no package-facing release note.
The PR also removes an unused
globbyinstall from the PR title-linter workflow. Its dependency download was returning a registry 404 before commitlint could check the title; the title check passes after removing it.DOCS-12215
Checklist
CLERK_COOKIE_PATcan dispatch workflows inclerk/clerk(fine-grained PAT:clerk/clerkrepository access with Actions read/write; classic PAT:reposcope and repository access).Other
pnpm testruns as expected. (Not run; workflow and documentation changes.)pnpm buildruns as expected. (Not run; workflow and documentation changes.)docs/CICD.mdanddocs/CONTRIBUTING.mdwere updated; the companion PR updates docs contributor guidance.)Type of change