fix(repo): use canonical Dashboard links and ban legacy last-active URLs - #9653
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: d69d48f The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (21)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: 7 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour. 📝 WalkthroughWalkthroughUpdated Clerk Dashboard links across runtime guidance, documentation, migration guides, and integration fixtures. Added a CLI checker with tests, package and lint integration, and a CI validation step. Added a changeset for affected packages. Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change updates Dashboard links and adds validation to prevent legacy URLs from returning. No merge-blocking current-head risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 14 files. (10 skipped: 10 unsupported.)
Warning Linked repositories: Your configuration references 7 linked repositories, but your current plan allows 5. Analyzed Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
Replace every remaining `dashboard.clerk.com/last-active?path=…` link in JSDoc, error messages, READMEs, and upgrade guides with the `/~/…` active-instance shortcut, and add `scripts/check-dashboard-links.mjs` so CI fails on any new `/last-active` link. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Pushed some changes directly in d69d48f.
|
Description
Clerk Dashboard links across the SDKs still used the legacy
https://dashboard.clerk.com/last-active?path=…URL. It resolves, so the docs link checker in clerk/clerk couldn't tell it apart from a broken link, and the 12 generated TypeDoc links it produced on the backend and Next.js reference pages kept passing validation.This PR replaces every remaining
/last-activelink with the canonical active-instance shortcut,https://dashboard.clerk.com/~/…: the backendpublishableKey,secretKey, andjwtKeyJSDoc that feeds TypeDoc, the matchingpublishableKeyJSDoc in@clerk/sharedand@clerk/chrome-extension, the missing-key and billing error messages in@clerk/shared, the native API error in@clerk/expo, the keyless prompt fallback in@clerk/ui, the@clerk/expressand@clerk/chrome-extensionREADMEs, and the core-2 upgrade guides.It also adds
scripts/check-dashboard-links.mjs, run aspnpm lint:dashboard-linksin the CI pre-checks job and inpnpm lint. It scans tracked files for Dashboard URLs whose path is/last-activeand fails with the/~/replacement for each hit. It doesn't validate that a route exists; clerk/clerk keeps doing that against the Dashboard route snapshot.The companion docs PR, https://github.com/clerk/clerk/pull/3294, syncs the generated TypeDoc output and bans
/last-activeon the docs side. Linear: https://linear.app/clerk/issue/DOCS-12082Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change