Repository navigation
Conversation
This is the change of clerk/clerk-ios#688 for the Expo package. The twelve files that src/core/MANIFEST lists, nine test files, the iOS backend, and the publish script are byte copies of the files there. attach posts what its flags name: --screenshot <label> for each screenshot, --video, or both, and --before <run-id> adds the run on the build without the change. The block is one result line and a table with 280 px images. run closes the app and starts the recorder at the first host.launch, so a video no longer opens on the screen that the run before it left. attach refuses a closed or merged pull request, and prints "already posted" only when the description holds the block it would write. A hand-off carries the before files in version 2 of the manifest, and scripts/verify-attach.mjs checks each new thing it accepts. The fix lines for a missing iOS template simulator now give simctl create. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A retried open signals that the app is about to launch a second time, after the new sign-in ticket of that try. The CLI answers the second signal from the recorder it already started: it closes nothing and starts no second recorder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 9354f2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
mikepitre
added this pull request to stack #10100
October 13, 2026 23:06
attach read the upload addresses back from the block in table order and laid the block out again as if they were in upload order. With a before run a row shows the before cell first, so the two never matched, and an identical attach uploaded every file again. The comparison no longer depends on the order: the block there must be the block attach would write, with any upload address in each place. publish.ts and the test are byte copies of clerk/clerk-ios#689. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
This was referenced Oct 14, 2026
Draft
Draft
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the same change as clerk/clerk-ios#688, which is merged, for the Expo package in
integration/expo-native/. That description has the reasons, and it says what each new check in the publish script is for. clerk/clerk-android#1088 is the same change for clerk-android. This PR sits on #10163 and is the sixth of the stack. Its third commit is the fix of clerk/clerk-ios#689.Before this PR,
attachcould post only the video and the screenshots of one passing run. A video opened on the screen that the run before it left, and the app restarted before the test began. After this PR:attachposts only what its flags name. Pass--screenshot <label>once for each screenshot,--video, or both. With neither flag it fails with a usage error that says how to choose.--before <run-id>adds a run of the same spec on the build without the change. That run can have failed.Beforeand anAftercolumn. A screenshot is 280 pixels wide.runcloses the app and starts the recorder when the first test is about to launch the app. A run in which no test callshost.launchhas no video.attachrefuses a closed or merged pull request. It printsalready postedonly when the description holds the exact block it would write.scripts/verify-attach.mjsgains the checks that feat(verify): post the evidence that shows the change, before and after clerk-ios#688 lists.The twelve files that
integration/expo-native/src/core/MANIFESTlists, nine test files,src/platform/ios/local.ts, and the publish script are byte copies of the files that clerk/clerk-ios#688 put onmainthere, atc88bdf0af.publish.tsandtest/evidence.test.tsare the files of clerk/clerk-ios#689.scripts/verify-attach.test.mjsdiffers from the file there in one line, which importsdescribeanditfromvitest.verify-attach.ymldoes not change.Four things differ from clerk/clerk-ios#688:
attachfails with a usage error when it is not. The description still holds one block for each platform.adb. There the CLI closes the app and startsscreenrecord, and then the test stops the app again and starts its activity. A retried open on that path repeats only the last step, so it does not signal a second time.features/README.md, andreferences/remote.mdsay the same things in the words of this repository.The changeset is empty, as it is in the other PRs of the stack. No published package changes.
What this can break:
attach <run-id> --pr <n>with no other flag now fails.main, the workflow refuses a hand-off from a branch whose verify code is older, and only the run ofverify-attachshows the refusal.verify-e2e.ymlrecords video. A recorder that cannot start now fails each test that launches the app. Before this PR it stopped the run before any test.Look hardest at these:
scripts/verify-attach.mjs, with 203 lines added and 67 removed. It is the only code here that runs with the bot token. It is the file of feat(verify): post the evidence that shows the change, before and after clerk-ios#688, so one read covers both.runinintegration/expo-native/src/core/verbs.ts. The recorder now starts in the middle of a test.npm testinintegration/expo-native/passes 787 of 787 at9354f2b8e7, where #10163 has 752, andnpm run typecheckis clean.vitest run --root scripts verify-attachpasses 190 of 190, where #10163 has 143. Each of 46 deliberate breaks of the code fails at least one test. They are the 43 of the last round of clerk/clerk-ios#688, two for the new tests, and one for the fix.verify-e2epassed at9354f2b8e7, and no test needed its retry. On iOS all 17 tests passed. On Android 15 passed, and the other two are for iOS only. The iOS video opens on the simulator's home screen for about two and a half seconds, and the Android video opens on the launcher for about a second and a half. Then the app opens.On a local Android emulator, after one
up,custom-flow-sign-in/completeran twice with video and passed both times. Those runs came before the third commit, which changes only howattachcompares a block. Frames of the first three seconds of the second run, three a second, show the splash screen of the app, the dev client as it loads the bundle, and then the test. No frame shows the launcher, and the app starts once. The block at the end of this description isattach --videoof that run, from the CLI of this branch. Its last seconds show the address, the test code, and the user and session IDs of a test user.downhas deleted that user with its application.Not proven:
verify-attachworkflow with this script. GitHub starts it only frommain.The example on clerk/clerk-android#1088 showed one defect in the shared code. A second
attachof the same run with--beforeuploaded the files again and printedposted, where it should printalready posted. The third commit takes the fix from clerk/clerk-ios#689, with its test. Noattachwith--beforewas made on this pull request.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Verified on an Android emulator. Run
r20261013-190853-8110onverify-android-1 (emulator-5560)at3e6d7798a8b3, 1 of 1 passed.videoevidence-ef0a6ed02466e06c-1.mp4
🤖 Generated with Claude Code