fix: sync PaymentMethodsType enum with Flow API spec - #213
armando-rodriguez-cko wants to merge 1 commit into
Conversation
🔴 Risk Classification: MAJORApproval route: AI Review + Human Approval Required Classification reasons
Operational gates
Files analysed: 1 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
🔵 Advisory review: Sound, but needs your judgementThis PR needs a human approval. The code itself reads as correct; whether it should land depends on context I don't have. Adds 26 new payment method constants and deprecates giropay/sofort to sync the enum with the Flow API spec; the change looks mechanically correct but the REMEMBER_ME constant has unusual handling that warrants explicit sign-off. For you to decide
This is not an approval. wall-e cannot auto-approve this PR — it is an opinion to help whoever does. Advisory review · us.anthropic.claude-sonnet-4-6 · wall-e 2026.06.19-02 |
Adds 26 payment methods missing from the enum (alipay_cn, alipay_hk, alma, benefit, bizum, dana, gcash, kakaopay, klarna, mbway, mobilepay, octopus, paynow, plaid, qpay, remember_me, sepa, stcpay, stored_card, tabby, tamara, tng, truemoney, twint, vipps, wechatpay) and marks giropay and sofort as deprecated since they are no longer part of the specification. Related to checkout/checkout-sdk-php#338 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
e215aa5 to
c1ac250
Compare
🔴 Risk Classification: MAJORApproval route: AI Review + Human Approval Required Classification reasons
Operational gates
Files analysed: 1 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
|



Summary
PaymentMethodsType(alipay_cn, alipay_hk, alma, benefit, bizum, dana, gcash, kakaopay, klarna, mbway, mobilepay, octopus, paynow, plaid, qpay, remember_me, sepa, stcpay, stored_card, tabby, tamara, tng, truemoney, twint, vipps, wechatpay), keeping the enum in sync with the Flow API'senabled_payment_methods/disabled_payment_methodsvalues.giropayandsofortas deprecated since they are no longer part of the specification, without removing them (backward compatibility).Related to checkout/checkout-sdk-php#338 (same enum drift found on the PHP SDK)
Test plan
PaymentMethodsType, no test changes needed