Skip to content

Release 4.5.0 - Airline and accommodation sub-tree model alignment - #247

Merged
david-ruiz-cko merged 1 commit into
mainfrom
release/4.5.0
Sep 30, 2026
Merged

david-ruiz-cko merged 1 commit into
mainfrom
release/4.5.0

Conversation

@david-ruiz-cko

Copy link
Copy Markdown
Contributor

This release significantly improves the structure, documentation, and correctness of the payment processing models in the SDK, particularly around airline and accommodation data. It introduces new classes for airline and accommodation details, corrects data shapes to match the API specification, and adds comprehensive docstrings and field-level comments for clarity.

Improvements to Airline and Accommodation Data Models:

  • Introduced new classes (Ticket, Passenger, PassengerAddress, FlightLegDetails, AirlineData, AccommodationPhone, AccommodationAddress, AccommodationGuest, AccommodationRoom, AccommodationData) with detailed docstrings and field-level comments to accurately represent the API schema and improve code readability. (F17f0249L532R532)
  • Corrected the data shape for airline and passenger fields in both PaymentContextsAirlineData and ProcessingSettings to use single objects instead of lists, matching the API's expected input and preventing request errors. (checkout_sdk/payments/contexts/contexts.pyL3-R165, F17f0249L532R532)

Enhancements to Processing Settings:

  • Expanded the ProcessingSettings class with detailed docstrings and field-level comments, and added missing fields to ensure full coverage of the current API specification. (F17f0249L532R532)
  • Clarified handling of deprecated and backwards-compatible fields, especially around SenderInformation, to guide developers and prevent misuse. (checkout_sdk/payments/payments.pyL515-R520, F17f0249L532R532)

General Documentation and Consistency:

These changes ensure the SDK models are in sync with the latest API requirements, reduce integration errors, and provide clearer guidance for developers working with complex payment data.

@david-ruiz-cko
david-ruiz-cko requested a review from a team September 29, 2026 15:39
@agent-wall-e

agent-wall-e Bot commented Sep 29, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • no_low_class_matched
  • prod_source_modified

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Sep 29, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Sep 29, 2026

Copy link
Copy Markdown

🟠 Advisory review: Concerns worth a look

This PR needs a human approval. Before you give it, these are the things I'd want resolved.

The diff only shows a version bump from 4.4.0 to 4.5.0, but the PR description claims substantial model changes to airline/accommodation classes and ProcessingSettings; those changes are not present in the diff provided.

Concerns

  • The diff is incomplete — all claimed changes to checkout_sdk/payments/contexts/contexts.py, checkout_sdk/payments/payments.py, and the new model classes are missing from what was supplied for review.
  • It is impossible to verify the claim that 'data shapes were corrected to use single objects instead of lists' without seeing the actual model changes.
  • The version bump to 4.5.0 should only be approved once the full diff has been reviewed and the substantive changes confirmed correct.

This is not an approval. wall-e cannot auto-approve this PR — it is an opinion to help whoever does. Advisory review · us.anthropic.claude-sonnet-4-6 · wall-e 2026.06.19-02

@sonarqubecloud

Copy link
Copy Markdown

@david-ruiz-cko
david-ruiz-cko merged commit 9265322 into main Sep 30, 2026
4 checks passed
@david-ruiz-cko
david-ruiz-cko deleted the release/4.5.0 branch September 30, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants