Stop dependency auto-update for helmfile v0.171 variants#4340
Merged
Conversation
Remove variant.mod and variant.lock so the EOL helmfile 0.x variants are no longer picked up by the Update dependencies workflow. Directories and the pinned v0.171.0 image build are kept intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background / Why
The
Update dependenciesjob of themodvariant fails on every run, sending an error notification each time.The cause is the two directories
argocd-helmfile-v0171/argocd-helmfile-plugin-v0171, which constrain helmfile to< 1.0(the 0.x line).modonly inspects the latest 30 GitHub releases (the first page) and does not paginate. helmfile has moved to the 1.x line and stopped updating 0.x (last release: v0.171.0). As more 1.x releases piled up, v0.171.0 was pushed out of the latest-30 window and is no longer visible tomod, so no version matching< 1.0can be found and dependency resolution fails. helmfile 0.x will not be updated again, so this auto-update can never succeed.What this PR does
Removes
variant.modandvariant.lockfrom the following two directories so they are no longer matched by thels */variant.modloop and are excluded from the auto-update:argocd-helmfile-v0171argocd-helmfile-plugin-v0171The directories themselves and the pinned v0.171.0 image build are kept intact. Only the automatic dependency update is disabled.
Out of scope
argocd-helmfile-v0171/argocd-helmfile-plugin-v0171directories