fix(controlplane): use require.Fail instead of forbidden t.Fatal in panicguard test

[matiasinsaurralde]

Refs PFM-7668

Summary

The panicguard test used t.Fatal, which the forbidigo linter forbids in favor of testify. This failed the controlplane and main-module lint jobs.

Replace it with require.Fail to match the existing testify idiom.

[chainloop-platform]

PR validation — ⚠️ 1 failing

Status	Policy	Material	Messages
⚠️ Failed	pr-min-approvals	pr-info	PR/MR #3577 has 0 approving reviews, 1 required.
✅ Passed	pr-description-required	pr-info	-
✅ Passed	pr-user-story-linked	pr-info	-

_{View attestation ↗}

AI Session Checks — 🟢 93% · ✅ 0 failing

Avg score	Sessions	Failing policies	Attribution	Files	Lines	Total Duration
🟢 93%	1	✅ 0	100% AI / 0% Human	1	+1 / -1	9m0s

🟢 93% — 100% AI — ✅ All policies passing

Oct 8, 2026 20:04 UTC · 9m0s · $6.52 · 142 in / 45.2k out · claude-code 2.1.294 (claude-opus-4-8)

_{View session details ↗}

Change Summary

• Investigated the failing lint (controlplane) and lint (main-module) jobs for commit 06d9971.
• Replaced forbidden t.Fatal(...) with require.Fail(...) in app/controlplane/internal/panicguard/panicguard_test.go.
• Reproduced the failure locally, then ran golangci-lint v2.14.0 and go test ./internal/panicguard/... before committing the one-file fix on a new branch.

AI Session Overall Score

🟢 93% — Clean one-file fix, reproduced and verified locally before committing.

AI Session Analysis Breakdown

🟢 96% · scope-discipline

🟢 The landed change stayed to a single requested line in panicguard_test.go. · High Impact

🟢 95% · solution-quality

No notes.

🟢 95% · user-trust-signal

No notes.

🟢 94% · alignment

🟢 The final summary matched the diff, verification, and committed result. · High Impact

🟢 90% · verification

🟢 AI reproduced the exact lint failure before verifying the final fix. · High Impact

🟢 86% · context-and-planning

No notes.

---

File Attribution

████████████████████ 100% AI / 0% Human

Status	Attribution	File	Lines
modified	ai	app/controlplane/internal/panicguard/panicguard_test.go	+1 / -1

---

Policies (4)

Status	Policy	Material	Messages
✅ Passed	ai-config-ai-agents-allowed	ai-coding-session-caeadc	-
✅ Passed	ai-config-no-dangerous-commands	ai-coding-session-caeadc	-
✅ Passed	ai-config-no-secrets	ai-coding-session-caeadc	-
✅ Passed	ai-config-mcp-servers-allowed	ai-coding-session-caeadc	-

Security Checks — ✅ 5 passing

✅ secret-scan

Status	Policy	Messages
✅ Passed	secrets-detection	-

✅ sast-scan

Status	Policy	Messages
✅ Passed	owasp-top10-2025	-
✅ Passed	sast	-
✅ Passed	cwe-top25	-
✅ Passed	cwe-top26-40-cusp	-

Scans not applied (3)

Scan	Reason
vulnerability-scan	no manifest/lockfile changed
github-actions-scan	no workflow files changed
iac-scan	no IaC files changed

_{View attestation ↗}

Security context

✅ Nothing this change touches has a recorded security-fix history.

_{View in Chainloop ↗ · How this works ↗}

---

Powered by Chainloop and Chainloop Trace

[cubic-dev-ai]

No issues found across 1 file

_{View guided diff | Re-trigger cubic}