Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

currentRootSpan != root on notifyStart #534

Description

@jinmel

Please answer these questions before submitting a bug report.

What version of OpenCensus are you using?

0.0.12

What version of Node are you using?

10

What did you do?

If possible, provide a recipe for reproducing the error.

just run examples/grpc server and client with logLevel: 'debug' on tracer

What did you expect to see?

What did you see instead?

[debug] "2019-05-17T09:51:38.568Z" 'currentRootSpan != root on notifyStart. Need more investigation.'
[debug] "2019-05-17T09:51:38.568Z" 'starting to notify listeners the start of spans'
[debug] "2019-05-17T09:51:38.652Z" 'currentRootSpan != root on notifyEnd. Need more investigation.'
[debug] "2019-05-17T09:51:38.652Z" 'starting to notify listeners the end of spans'

Additional context

tracer.startRootSpan calls base_tracer.startRootSpan which then calls rootspan.start().

rootspan.start() calls tracer.onStartSpan() and there it checks whether currentRootSpan is equal to root span that is requested to be started.

Is this correct for any reason? if a new root span is created, it SHOULD be different from currentRootSpan.

This symptom happens for all instrumentation, http, grpc, mongodb and so on.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions