Skip to content

fix(pr-review-toolkit): ask approval after preview - #107

Merged
cblecker merged 1 commit into
mainfrom
fix/pr-review-approval-ordering
Sep 25, 2026
Merged

cblecker merged 1 commit into
mainfrom
fix/pr-review-approval-ordering

Conversation

@cblecker

@cblecker cblecker commented Sep 25, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • The posting approval AskUserQuestion could fire before the drafted preview was shown, or in parallel with the line-anchor git diff checks, so the user was asked to approve a draft they hadn't seen yet.
  • posting.md now says to ask for approval only after the anchor checks have returned and the full preview text is in the conversation, with the question called alone.
  • Bumps pr-review-toolkit to 2.3.1.

Test plan

  • claude plugin validate .
  • Run /pr-review-toolkit:review-pr on a PR with a recommended finding, choose "Draft recommended findings", and confirm the preview appears before the approval question

This PR was written in part with the assistance of generative AI.

Summary by CodeRabbit

  • Updates
    • Updated the plugin version to 2.3.1.
    • Approval prompts now appear after line-anchor checks are complete and the full preview is available. The prompt is presented separately from other tool calls.

The posting approval question could fire before the drafted preview was
shown, or in parallel with the line-anchor checks, so the user was asked
to approve a draft they had not seen.

Assisted-by: LLM
Copilot AI balanced review requested due to automatic review settings September 25, 2026 00:30
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: cblecker/claude-plugins/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 4b3dea6a-0db0-4b3a-a42d-d515fa36e97b

📥 Commits

Reviewing files that changed from the base of the PR and between 7fe6c32 and de292f8.

📒 Files selected for processing (2)
  • pr-review-toolkit/.claude-plugin/plugin.json
  • pr-review-toolkit/skills/review-pr/references/posting.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR updates the plugin version from 2.3.0 to 2.3.1. It also changes the review-posting instructions to gate the approval prompt on completed line-anchor checks and display of the full preview.

Changes

Review approval instructions

Layer / File(s) Summary
Approval gating
pr-review-toolkit/skills/review-pr/references/posting.md
The instructions require line-anchor checks to finish and the full preview to appear before requesting approval. They also require calling AskUserQuestion alone, not in parallel with other tools. Approval options are unchanged.

Plugin version

Layer / File(s) Summary
Plugin version update
pr-review-toolkit/.claude-plugin/plugin.json
The declared plugin version changes from 2.3.0 to 2.3.1.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to de292

The full review preview and completed anchor checks precede posting approval, and the plugin version is updated to 2.3.1. No concrete PR-introduced issue remains to block merging.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: requesting approval only after the preview is available.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused documentation fix is consistent with the review workflow and versioning policy.

Review effort: Balanced
Findings: None

What changed in this PR

Ensures review previews appear before approval is requested.

Changes:

  • Serializes anchor checks, preview display, and approval prompting.
  • Bumps the plugin patch version to 2.3.1.
File Description
posting.md Clarifies approval sequencing.
plugin.json Applies the required patch bump.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@cblecker
cblecker merged commit 218dcee into main Sep 25, 2026
15 checks passed
@cblecker
cblecker deleted the fix/pr-review-approval-ordering branch September 25, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants