fix(pr-review-toolkit): ask approval after preview - #107
Conversation
The posting approval question could fire before the drafted preview was shown, or in parallel with the line-anchor checks, so the user was asked to approve a draft they had not seen. Assisted-by: LLM
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: cblecker/claude-plugins/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR updates the plugin version from 2.3.0 to 2.3.1. It also changes the review-posting instructions to gate the approval prompt on completed line-anchor checks and display of the full preview. ChangesReview approval instructions
Plugin version
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The full review preview and completed anchor checks precede posting approval, and the plugin version is updated to 2.3.1. No concrete PR-introduced issue remains to block merging. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused documentation fix is consistent with the review workflow and versioning policy.
Review effort: Balanced
Findings: None
What changed in this PR
Ensures review previews appear before approval is requested.
Changes:
- Serializes anchor checks, preview display, and approval prompting.
- Bumps the plugin patch version to 2.3.1.
| File | Description |
|---|---|
posting.md |
Clarifies approval sequencing. |
plugin.json |
Applies the required patch bump. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
AskUserQuestioncould fire before the drafted preview was shown, or in parallel with the line-anchorgit diffchecks, so the user was asked to approve a draft they hadn't seen yet.posting.mdnow says to ask for approval only after the anchor checks have returned and the full preview text is in the conversation, with the question called alone.Test plan
claude plugin validate ./pr-review-toolkit:review-pron a PR with a recommended finding, choose "Draft recommended findings", and confirm the preview appears before the approval questionThis PR was written in part with the assistance of generative AI.
Summary by CodeRabbit